Use event.kind to validate if there is any pipeline error#3330
Merged
mrodm merged 8 commits intoelastic:mainfrom Mar 4, 2026
Merged
Use event.kind to validate if there is any pipeline error#3330mrodm merged 8 commits intoelastic:mainfrom
mrodm merged 8 commits intoelastic:mainfrom
Conversation
af55cbb to
0110191
Compare
Contributor
Author
|
test integrations |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#17636 |
Validate if `event.kind` field contains `pipeline_error` to decide if there is any error. When there is an error check also `error.message` field.
Added test package as false positive to validate that errors from pipeline are detected in system tests.
3a6142f to
138d221
Compare
Contributor
Author
|
Created another PR to test packages in integrations elastic/integrations#17639 This PR includes the changes of this revert #3331 |
teresaromero
reviewed
Mar 4, 2026
| # Dump stack logs | ||
| # Required containers could not be running, so ignore the error | ||
| elastic-package stack dump -v --output "build/elastic-stack-dump/check-${SUFFIX_FOLDER_DUMP_LOGS}}" || true | ||
| elastic-package stack dump -v --output "build/elastic-stack-dump/check-${SUFFIX_FOLDER_DUMP_LOGS}" || true |
teresaromero
reviewed
Mar 4, 2026
teresaromero
approved these changes
Mar 4, 2026
jsoriano
reviewed
Mar 4, 2026
Member
jsoriano
left a comment
There was a problem hiding this comment.
LGTM, added a couple of small suggestions.
Comment on lines
+2489
to
+2491
| if errorMessage == "" { | ||
| return "found pipeline_error in document: no error message" | ||
| } |
Member
There was a problem hiding this comment.
Before this change we would ignore the absence of error.message, but now that we are checking if the event is a pipeline error I think it is better to report something, even if the error is not present. 👍
jsoriano
approved these changes
Mar 4, 2026
Collaborator
💚 Build Succeeded
History
cc @mrodm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate if
event.kindfield containspipeline_errorto decide if there is any error. When there is an error check alsoerror.messagefield.Considerations:
event.kindanderror.messagefields are ignored.Author's Checklist
erroras a list of strings in zipkin (relates Add zipkin_input_otel package for Zipkin trace collection integrations#17226)Closes #1392