Revert go-ucfg dependency to v0.8.8#3331
Merged
mrodm merged 2 commits intoelastic:mainfrom Mar 3, 2026
Merged
Conversation
Collaborator
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @mrodm |
mrodm
commented
Mar 3, 2026
Comment on lines
+53
to
+54
| v, err := cfg.Vars.GetValue("data_stream.dataset") | ||
| require.NoError(t, err) |
Contributor
Author
There was a problem hiding this comment.
This was not found in v0.9.0
Error: Received unexpected error: key not found
Test: TestNewConfig/vars_with_data_stream.dataset_are_detected
teresaromero
approved these changes
Mar 3, 2026
3 tasks
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the
go-ucfgupgrade to v0.9.0 #3294It keeps the version v0.8.0
The issue found is related to variables containing dots like
data_stream.datasetthat cannot be retrieve from the config.Given this configuration file for system tests
This call would return key not found (if err was validated):
elastic-package/internal/testrunner/runners/system/tester.go
Lines 2073 to 2076 in a3061de
Author's Checklist
data_stream.dataset)