[CI] Allow to run each cloud cleanup step independently in DRY_RUN false mode#2581
Merged
mrodm merged 9 commits intoelastic:mainfrom May 8, 2025
Merged
Conversation
Use different DRY_RUN env. vars for each step.
9c15c2b to
7054f85
Compare
Collaborator
💚 Build Succeeded
History
cc @mrodm |
jsoriano
reviewed
May 7, 2025
Member
jsoriano
left a comment
There was a problem hiding this comment.
I don't fully understand this PR 🤔 How would we run each step independently with DRY_RUN false?
Contributor
Author
Sorry, I did not add that explanation. These changes introduce a new selector in the Buildkite UI, so the user can select which step is going to be run in DRY_RUN mode.
|
Member
|
Oh ok, I misunderstood, I thought that we were fully deprecating the current variable, but I was missing what was replacing it. Thanks. |
jsoriano
approved these changes
May 7, 2025
v1v
added a commit
to v1v/elastic-package
that referenced
this pull request
May 8, 2025
* main: chore: [updatecli] Update latest snapshot to 9.1.0-4348ed5d (elastic#2582) [CI] Allow to run each cloud cleanup step independently in DRY_RUN false mode (elastic#2581) buildkite: use GCP OIDC (elastic#2569) Replace archiver dependency (elastic#2564) github-action: add catalog-validate for GitHub actions (elastic#2576) chore: [updatecli] Update latest snapshot to 9.1.0-62329fee (elastic#2580) Chore(deps): bump golang.org/x/tools from 0.32.0 to 0.33.0 (elastic#2577) Chore(deps): bump gotest.tools/gotestsum from 1.12.1 to 1.12.2 (elastic#2578)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use different DRY_RUN environment variable names for each step to be able to choose which one to enable.