feat(tooltip): series tick formatters#802
Merged
nickofthyme merged 3 commits intoelastic:masterfrom Sep 4, 2020
Merged
Conversation
monfera
approved these changes
Sep 4, 2020
Contributor
monfera
left a comment
There was a problem hiding this comment.
Works and looks great, code kept simple, widespread tests!
markov00
pushed a commit
that referenced
this pull request
Sep 6, 2020
# [21.1.0](v21.0.1...v21.1.0) (2020-09-06) ### Bug Fixes * **axis:** misaligned axis with rotated histogram bar charts ([#805](#805)) ([6c454e1](6c454e1)) ### Features * **brush:** histogram brushing last values and rounding ([#801](#801)) ([6d0319f](6d0319f)) * **tooltip:** series tick formatters ([#802](#802)) ([fbcd92e](fbcd92e))
Collaborator
|
🎉 This PR is included in version 21.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [21.1.0](elastic/elastic-charts@v21.0.1...v21.1.0) (2020-09-06) ### Bug Fixes * **axis:** misaligned axis with rotated histogram bar charts ([opensearch-project#805](elastic/elastic-charts#805)) ([a52a692](elastic/elastic-charts@a52a692)) ### Features * **brush:** histogram brushing last values and rounding ([opensearch-project#801](elastic/elastic-charts#801)) ([867abbc](elastic/elastic-charts@867abbc)) * **tooltip:** series tick formatters ([opensearch-project#802](elastic/elastic-charts#802)) ([813b915](elastic/elastic-charts@813b915))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for elastic/kibana#74951.
Allow
SeriesSpecto havetickFormatfor different tooltip formatted values.Set different axes formatter
Axis formatter defaults to first series formatter
Axis formatter defaults to default formatter with no series formatters
Checklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)