Skip to content

feat(brush): histogram brushing last values and rounding#801

Merged
nickofthyme merged 4 commits intoelastic:masterfrom
nickofthyme:feat/brush-improvements
Sep 4, 2020
Merged

feat(brush): histogram brushing last values and rounding#801
nickofthyme merged 4 commits intoelastic:masterfrom
nickofthyme:feat/brush-improvements

Conversation

@nickofthyme
Copy link
Copy Markdown
Collaborator

@nickofthyme nickofthyme commented Sep 3, 2020

Summary

Add props to Settings for improved brush interaction controls for histogram bar charts only

roundHistogramBrushValues

Boolean to round brushed values to nearest step bounds.

A brush selection range of [1.23, 3.6] with a domain of [1, 2, 3, 4].
when true returns [1, 3] and when false returns [1.23, 3.6]

Screen Recording 2020-09-03 at 03 55 PM

allowBrushingLastHistogramBucket

Boolean to allow brushing on last bucket even when outside domain or limit to end of domain.

A brush selection range of [1.23, 3.6] with a domain of [1, 2, 3]
when true returns [1.23, 3.6] and when false returns [1.23, 3]

Screen Recording 2020-09-03 at 03 55 PM

Checklist

Delete any items that are not applicable to this PR.

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme added the :vislib Relating to vislib replacement label Sep 3, 2020
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #801 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
+ Coverage   74.20%   74.23%   +0.02%     
==========================================
  Files         273      273              
  Lines        9309     9318       +9     
  Branches     2004     2007       +3     
==========================================
+ Hits         6908     6917       +9     
  Misses       2394     2394              
  Partials        7        7              
Flag Coverage Δ
#unittests 74.23% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/specs/settings.tsx 87.09% <ø> (ø)
...es/xy_chart/state/selectors/on_brush_end_caller.ts 88.57% <100.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a0fb97...9ea6fcb. Read the comment docs.

@nickofthyme nickofthyme merged commit 6d0319f into elastic:master Sep 4, 2020
@nickofthyme nickofthyme deleted the feat/brush-improvements branch September 4, 2020 21:40
markov00 pushed a commit that referenced this pull request Sep 6, 2020
# [21.1.0](v21.0.1...v21.1.0) (2020-09-06)

### Bug Fixes

* **axis:** misaligned axis with rotated histogram bar charts ([#805](#805)) ([6c454e1](6c454e1))

### Features

* **brush:** histogram brushing last values and rounding ([#801](#801)) ([6d0319f](6d0319f))
* **tooltip:** series tick formatters ([#802](#802)) ([fbcd92e](fbcd92e))
@markov00
Copy link
Copy Markdown
Collaborator

markov00 commented Sep 6, 2020

🎉 This PR is included in version 22.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Sep 6, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
# [21.1.0](elastic/elastic-charts@v21.0.1...v21.1.0) (2020-09-06)

### Bug Fixes

* **axis:** misaligned axis with rotated histogram bar charts ([opensearch-project#805](elastic/elastic-charts#805)) ([a52a692](elastic/elastic-charts@a52a692))

### Features

* **brush:** histogram brushing last values and rounding ([opensearch-project#801](elastic/elastic-charts#801)) ([867abbc](elastic/elastic-charts@867abbc))
* **tooltip:** series tick formatters ([opensearch-project#802](elastic/elastic-charts#802)) ([813b915](elastic/elastic-charts@813b915))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Issue released publicly :vislib Relating to vislib replacement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants