fix(partition): don't fill singleton slice if the inner radius is nonzero#643
Merged
monfera merged 2 commits intoelastic:masterfrom Apr 22, 2020
Merged
fix(partition): don't fill singleton slice if the inner radius is nonzero#643monfera merged 2 commits intoelastic:masterfrom
monfera merged 2 commits intoelastic:masterfrom
Conversation
markov00
approved these changes
Apr 22, 2020
Collaborator
markov00
left a comment
There was a problem hiding this comment.
Code LGTM, tested locally
markov00
pushed a commit
that referenced
this pull request
Apr 22, 2020
This commit fix the partition chart avoiding filling a single slice if the inner radius is nonzero. fix #637
markov00
pushed a commit
that referenced
this pull request
Apr 22, 2020
# [18.4.0](v18.3.0...v18.4.0) (2020-04-22) ### Bug Fixes * **partition:** single slice wrong text positioning ([#643](#643)) ([6298d36](6298d36)), closes [#637](#637) * **treemap:** align onElementClick parameters to sunburst ([#636](#636)) ([2c1d224](2c1d224)), closes [#624](#624) ### Features * allow colorVariant option for series specific color styles ([#630](#630)) ([e5a206d](e5a206d)) * **series:** BubbleSeries (alpha) and markSizeAccessor ([#559](#559)) ([3aa235e](3aa235e))
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [18.4.0](elastic/elastic-charts@v18.3.0...v18.4.0) (2020-04-22) ### Bug Fixes * **partition:** single slice wrong text positioning ([opensearch-project#643](elastic/elastic-charts#643)) ([f8b5b8a](elastic/elastic-charts@f8b5b8a)), closes [opensearch-project#637](elastic/elastic-charts#637) * **treemap:** align onElementClick parameters to sunburst ([opensearch-project#636](elastic/elastic-charts#636)) ([8dd87bf](elastic/elastic-charts@8dd87bf)), closes [opensearch-project#624](elastic/elastic-charts#624) ### Features * allow colorVariant option for series specific color styles ([opensearch-project#630](elastic/elastic-charts#630)) ([e2444ef](elastic/elastic-charts@e2444ef)) * **series:** BubbleSeries (alpha) and markSizeAccessor ([opensearch-project#559](elastic/elastic-charts#559)) ([85d9bda](elastic/elastic-charts@85d9bda))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the known bad storybook case and closes #637
It reveals text layout suboptimality in the face of Southern multirow placement in thin rings if the text is long and/or has some spaces, not addressed in this PR (preexisting issue will be linked later); temporary workaround against overzelaous line breaks: use of non-breaking space (unicode in JS string) as seen in the story source.
Bullseye chart?
Checklist
Delete any items that are not applicable to this PR.
Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)