fix(treemap): align onElementClick parameters to sunburst#636
Merged
markov00 merged 1 commit intoelastic:masterfrom Apr 21, 2020
Merged
fix(treemap): align onElementClick parameters to sunburst#636markov00 merged 1 commit intoelastic:masterfrom
markov00 merged 1 commit intoelastic:masterfrom
Conversation
This commit align the shape of passed parameter of the onElementClick listener to the one passed by a sunburst. For each single hovered shape (usually only one shape at time) it returns the values for each layer of the treemap fix elastic#624
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 66.44% 74.34% +7.90%
==========================================
Files 240 252 +12
Lines 7012 7192 +180
Branches 1340 1360 +20
==========================================
+ Hits 4659 5347 +688
+ Misses 2337 1821 -516
- Partials 16 24 +8
Continue to review full report at Codecov.
|
monfera
approved these changes
Apr 20, 2020
Contributor
monfera
left a comment
There was a problem hiding this comment.
LGTM, great test too, thanks!
| }; | ||
| } | ||
|
|
||
| function partToShapeTreeNode(treemapLayout: boolean, innerRadius: Radius, ringThickness: number) { |
Contributor
There was a problem hiding this comment.
Nice extraction! Should it be placed above the line in which we use it?
Collaborator
Author
There was a problem hiding this comment.
I've extracted that because I was having a hard time understanding the code.
My Place them the above the line that uses it, do you mean moving that function declaration before const quadViewModel = makeQuadViewModel( ?
Collaborator
There was a problem hiding this comment.
I think Robert is referring to preventing the function was used before it was declared error. Basically best practice even though hoisting prevents any errors.
nickofthyme
approved these changes
Apr 20, 2020
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM, verified issue is resolved. Tested 4_sunburst_slice_clicks story with changes.
markov00
pushed a commit
that referenced
this pull request
Apr 22, 2020
# [18.4.0](v18.3.0...v18.4.0) (2020-04-22) ### Bug Fixes * **partition:** single slice wrong text positioning ([#643](#643)) ([6298d36](6298d36)), closes [#637](#637) * **treemap:** align onElementClick parameters to sunburst ([#636](#636)) ([2c1d224](2c1d224)), closes [#624](#624) ### Features * allow colorVariant option for series specific color styles ([#630](#630)) ([e5a206d](e5a206d)) * **series:** BubbleSeries (alpha) and markSizeAccessor ([#559](#559)) ([3aa235e](3aa235e))
Collaborator
Author
|
🎉 This PR is included in version 18.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [18.4.0](elastic/elastic-charts@v18.3.0...v18.4.0) (2020-04-22) ### Bug Fixes * **partition:** single slice wrong text positioning ([opensearch-project#643](elastic/elastic-charts#643)) ([f8b5b8a](elastic/elastic-charts@f8b5b8a)), closes [opensearch-project#637](elastic/elastic-charts#637) * **treemap:** align onElementClick parameters to sunburst ([opensearch-project#636](elastic/elastic-charts#636)) ([8dd87bf](elastic/elastic-charts@8dd87bf)), closes [opensearch-project#624](elastic/elastic-charts#624) ### Features * allow colorVariant option for series specific color styles ([opensearch-project#630](elastic/elastic-charts#630)) ([e2444ef](elastic/elastic-charts@e2444ef)) * **series:** BubbleSeries (alpha) and markSizeAccessor ([opensearch-project#559](elastic/elastic-charts#559)) ([85d9bda](elastic/elastic-charts@85d9bda))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit aligns the shape of the passed parameter of the onElementClick listener to the one passed by a sunburst. For each single hovered shape (usually only one shape at a time) it returns the values for each layer of the treemap
fix #624
Checklist