fix: remove series with undefined splitSeriesAccessor values#627
Merged
markov00 merged 3 commits intoelastic:masterfrom Apr 14, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
=======================================
Coverage 67.78% 67.79%
=======================================
Files 236 236
Lines 6914 6916 +2
Branches 1275 1276 +1
=======================================
+ Hits 4687 4689 +2
Misses 2208 2208
Partials 19 19
Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Apr 10, 2020
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
Code changes look good. Tested storybook and looks good.
Would we ever want in the future to enable this functionality under other if a prop were passed, say includeMissingSplitGroups or something?
- change logic to exclude only if no splits are found but accessor is defined - remove all unnecessary split series accessors, per the new constraint above - add tooltip vrt for multple split and y accessors - remove tooltip visibility on 2y2g story - update necessary screenshots
markov00
added a commit
that referenced
this pull request
Apr 14, 2020
This commit removes every series generated from a partial datum where all the values accessed by the splitSeriesAccessors array are null or undefined. Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com>
markov00
pushed a commit
that referenced
this pull request
Apr 15, 2020
# [18.3.0](v18.2.2...v18.3.0) (2020-04-15) ### Bug Fixes * remove series with undefined splitSeriesAccessor values ([#627](#627)) ([59f0f6e](59f0f6e)) ### Features * gauge, goal and bullet graph (alpha) ([#614](#614)) ([5669178](5669178)) * **partition:** add legend and highlighters ([#616](#616)) ([6a4247e](6a4247e)), closes [#486](#486) [#532](#532)
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [18.3.0](elastic/elastic-charts@v18.2.2...v18.3.0) (2020-04-15) ### Bug Fixes * remove series with undefined splitSeriesAccessor values ([opensearch-project#627](elastic/elastic-charts#627)) ([e8bd5ea](elastic/elastic-charts@e8bd5ea)) ### Features * gauge, goal and bullet graph (alpha) ([opensearch-project#614](elastic/elastic-charts#614)) ([4191664](elastic/elastic-charts@4191664)) * **partition:** add legend and highlighters ([opensearch-project#616](elastic/elastic-charts#616)) ([b939596](elastic/elastic-charts@b939596)), closes [opensearch-project#486](elastic/elastic-charts#486) [opensearch-project#532](elastic/elastic-charts#532)
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes every series generated from a partial
datumwhere some or all the values accessed by thesplitSeriesAccessorsarray arenullorundefined.fix #594
Checklist
Delete any items that are not applicable to this PR.