[PURIFY] Remove certs and PKCS12 files temporarily#616
Merged
mihirsoni merged 1 commit intoopensearch-project:mainfrom Jul 9, 2021
Merged
[PURIFY] Remove certs and PKCS12 files temporarily#616mihirsoni merged 1 commit intoopensearch-project:mainfrom
mihirsoni merged 1 commit intoopensearch-project:mainfrom
Conversation
Collaborator
|
✅ DCO Check Passed 99892b2 |
Removed the generated keys from Elastic. Since we did not own those and do not have the private key for the cert authority then it will be safer. This should not have any impact on runtime, might impact security related to x-pack with demo certs but none of the certs where for production. Otherwise, this is strictly for testing. To be clear, this can be emptied out because it is ONLY for demo and testing purposes. The demo security can be accomplished by using: https://github.com/opensearch-project/security/blob/main/tools/install_demo_configuration.sh Eventually we should take the certs from that file and copy those over but will just ignore the tests for now. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
99892b2 to
de245fb
Compare
Collaborator
|
✅ DCO Check Passed de245fb |
ananzh
approved these changes
Jul 9, 2021
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Jul 9, 2021
…t#616) Removed the generated keys from Elastic. Since we did not own those and do not have the private key for the cert authority then it will be safer. This should not have any impact on runtime, might impact security related to x-pack with demo certs but none of the certs where for production. Otherwise, this is strictly for testing. To be clear, this can be emptied out because it is ONLY for demo and testing purposes. The demo security can be accomplished by using: https://github.com/opensearch-project/security/blob/main/tools/install_demo_configuration.sh Eventually we should take the certs from that file and copy those over but will just ignore the tests for now. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
5 tasks
kavilla
added a commit
that referenced
this pull request
Jul 9, 2021
Removed the generated keys from Elastic. Since we did not own those and do not have the private key for the cert authority then it will be safer. This should not have any impact on runtime, might impact security related to x-pack with demo certs but none of the certs where for production. Otherwise, this is strictly for testing. To be clear, this can be emptied out because it is ONLY for demo and testing purposes. The demo security can be accomplished by using: https://github.com/opensearch-project/security/blob/main/tools/install_demo_configuration.sh Eventually we should take the certs from that file and copy those over but will just ignore the tests for now. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Jul 9, 2021
Removed the generated keys from Elastic. Since we did not own those and do not have the private key for the cert authority then it will be safer. This should not have any impact on runtime, might impact security related to x-pack with demo certs but none of the certs where for production. Otherwise, this is strictly for testing. To be clear, this can be emptied out because it is ONLY for demo and testing purposes. The demo security can be accomplished by using: https://github.com/opensearch-project/security/blob/main/tools/install_demo_configuration.sh Eventually we should take the certs from that file and copy those over but will just ignore the tests for now. Original PR: opensearch-project#616 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
5 tasks
ananzh
pushed a commit
that referenced
this pull request
Jul 11, 2021
Removed the generated keys from Elastic. Since we did not own those and do not have the private key for the cert authority then it will be safer. This should not have any impact on runtime, might impact security related to x-pack with demo certs but none of the certs where for production. Otherwise, this is strictly for testing. To be clear, this can be emptied out because it is ONLY for demo and testing purposes. The demo security can be accomplished by using: https://github.com/opensearch-project/security/blob/main/tools/install_demo_configuration.sh Eventually we should take the certs from that file and copy those over but will just ignore the tests for now. Original PR: #616 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed the generated keys from Elastic. Since we did not own those
and do not have the private key for the cert authority then it will
be safer.
This should not have any impact on runtime, might impact security
related to x-pack with demo certs but none of the certs where
for production. Otherwise, this is strictly for testing.
To be clear, this can be emptied out because it is ONLY for demo
and testing purposes. The demo security can be accomplished by
using:
https://github.com/opensearch-project/security/blob/main/tools/install_demo_configuration.sh
Eventually we should take the certs from that file and copy those over but will
just ignore the tests for now.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
Purposefully didn't created one.
Check List