Skip to content

fix(tooltip): fix spec naming#412

Merged
nickofthyme merged 1 commit intoelastic:masterfrom
nickofthyme:fix/spec-naming
Oct 9, 2019
Merged

fix(tooltip): fix spec naming#412
nickofthyme merged 1 commit intoelastic:masterfrom
nickofthyme:fix/spec-naming

Conversation

@nickofthyme
Copy link
Copy Markdown
Collaborator

@nickofthyme nickofthyme commented Oct 9, 2019

Summary

set name to spec name then spec id

name is a global variable in ts and thus was not caught in the typecheck

closes #411

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@nickofthyme
fix(tooltip): fix spec naming
a9d047b 
set name to spec name then spec id

closes elastic#411
@nickofthyme nickofthyme requested a review from markov00 October 9, 2019 00:17
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #412 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #412   +/-   ##
=====================================
  Coverage      98%    98%           
=====================================
  Files          39     39           
  Lines        2853   2853           
  Branches      681    664   -17     
=====================================
  Hits         2796   2796           
  Misses         50     50           
  Partials        7      7
Impacted Files Coverage Δ
src/chart_types/xy_chart/tooltip/tooltip.ts 93.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81bac09...a9d047b. Read the comment docs.

markov00
markov00 approved these changes Oct 9, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickofthyme nickofthyme merged commit 3690cca into elastic:master Oct 9, 2019
markov00 pushed a commit that referenced this pull request Oct 9, 2019
@semantic-release-bot
chore(release): 13.4.1 [skip ci]
3b37328 
## [13.4.1](v13.4.0...v13.4.1) (2019-10-09)

### Bug Fixes

* **tooltip:** fix spec naming ([#412](#412)) ([3690cca](3690cca)), closes [#411](#411)
@markov00
Copy link
Copy Markdown
Collaborator

markov00 commented Oct 9, 2019

🎉 This PR is included in version 13.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 9, 2019
@nickofthyme nickofthyme deleted the fix/spec-naming branch October 9, 2019 13:51
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 13.4.1 [skip ci]
bf0b3ef 
## [13.4.1](elastic/elastic-charts@v13.4.0...v13.4.1) (2019-10-09)

### Bug Fixes

* **tooltip:** fix spec naming ([opensearch-project#412](elastic/elastic-charts#412)) ([01758fa](elastic/elastic-charts@01758fa)), closes [opensearch-project#411](elastic/elastic-charts#411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markov00 markov00 markov00 approved these changes

Assignees

No one assigned

Labels

released Issue released publicly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tooltip shows specId instead of name prop

3 participants

@nickofthyme @codecov-io @markov00