fix(tooltip): fix spec naming (#412)

nickofthyme · web-flow · commit 3690cca6be40 · 2019-10-09T08:08:00.000-05:00
set name to spec name then spec id closes #411
diff --git a/src/chart_types/xy_chart/tooltip/tooltip.test.ts b/src/chart_types/xy_chart/tooltip/tooltip.test.ts
@@ -95,6 +95,15 @@ describe('Tooltip formatting', () => {
     expect(tooltipValue.color).toBe('blue');
     expect(tooltipValue.value).toBe('10');
   });
+  it('should set name as spec name when provided', () => {
+    const name = 'test - spec';
+    const tooltipValue = formatTooltip(indexedBandedGeometry, { ...SPEC_1, name }, false, false, YAXIS_SPEC);
+    expect(tooltipValue.name).toBe(name);
+  });
+  it('should set name as spec id when name is not provided', () => {
+    const tooltipValue = formatTooltip(indexedBandedGeometry, SPEC_1, false, false, YAXIS_SPEC);
+    expect(tooltipValue.name).toBe(SPEC_1.id);
+  });
   test('format banded tooltip - upper', () => {
     const tooltipValue = formatTooltip(indexedBandedGeometry, bandedSpec, false, false, YAXIS_SPEC);
     expect(tooltipValue.name).toBe('bar_1 - upper');
diff --git a/src/chart_types/xy_chart/tooltip/tooltip.ts b/src/chart_types/xy_chart/tooltip/tooltip.ts
@@ -55,7 +55,7 @@ export function formatTooltip(
   if (seriesKey.length > 0) {
     displayName = seriesKey.join(' - ');
   } else {
-    displayName = name || `${spec.id}`;
+    displayName = spec.name || `${spec.id}`;
   }
 
   if (isBandedSpec(spec.y0Accessors) && (isAreaSeriesSpec(spec) || isBarSeriesSpec(spec))) {

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ export function formatTooltip(`
`55`	`55`	`if (seriesKey.length > 0) {`
`56`	`56`	`displayName = seriesKey.join(' - ');`
`57`	`57`	`} else {`
`58`		- displayName = name \|\| `${spec.id}`;
	`58`	+ displayName = spec.name \|\| `${spec.id}`;
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`if (isBandedSpec(spec.y0Accessors) && (isAreaSeriesSpec(spec) \|\| isBarSeriesSpec(spec))) {`