Skip to content

feat: banded legend values#408

Merged
nickofthyme merged 1 commit intoelastic:masterfrom
nickofthyme:feat/banded-legend-values
Oct 7, 2019
Merged

feat: banded legend values#408
nickofthyme merged 1 commit intoelastic:masterfrom
nickofthyme:feat/banded-legend-values

Conversation

@nickofthyme
Copy link
Copy Markdown
Collaborator

@nickofthyme nickofthyme commented Oct 7, 2019

Summary

  • Allow user to set postfix for upper and lower bound of banded series to distinguish between values sets
  • Update displayValue type changes, fix defaulting point values from 0 to null.

Hard naming fix for #398

closes #162

Checklist

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

- Allow user to set postfix for upper and lower bound of banded series to distinguish between values sets
- Update `displayValue` type changes, fix defaulting point values from 0 to null.

closes elastic#162
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 7, 2019

Codecov Report

Merging #408 into master will decrease coverage by 0.05%.
The diff coverage is 92.1%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #408      +/-   ##
========================================
- Coverage   98.05%    98%   -0.06%     
========================================
  Files          39     39              
  Lines        2833   2853      +20     
  Branches      673    681       +8     
========================================
+ Hits         2778   2796      +18     
  Misses         50     50              
- Partials        5      7       +2
Impacted Files Coverage Δ
src/chart_types/xy_chart/utils/specs.ts 100% <ø> (ø) ⬆️
...chart_types/xy_chart/utils/stacked_series_utils.ts 98.21% <100%> (ø) ⬆️
src/chart_types/xy_chart/store/utils.ts 96.76% <100%> (+0.05%) ⬆️
src/chart_types/xy_chart/utils/series.ts 100% <100%> (ø) ⬆️
src/chart_types/xy_chart/legend/legend.ts 95% <88.23%> (-5%) ⬇️
src/chart_types/xy_chart/tooltip/tooltip.ts 93.75% <89.47%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963d1ac...e37ae4c. Read the comment docs.

@nickofthyme nickofthyme merged commit 5c35a4d into elastic:master Oct 7, 2019
@nickofthyme nickofthyme deleted the feat/banded-legend-values branch October 7, 2019 21:23
markov00 pushed a commit that referenced this pull request Oct 7, 2019
# [13.4.0](v13.3.0...v13.4.0) (2019-10-07)

### Features

* banded legend values ([#398](#398) & [#408](#408)) ([5c35a4d](5c35a4d)), closes [#162](#162)
@markov00
Copy link
Copy Markdown
Collaborator

markov00 commented Oct 7, 2019

🎉 This PR is included in version 13.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Issue released publicly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display y0 and y1 names on tooltip for band charts

3 participants