Merged
Conversation
Allow user to set postfix for upper and lower bound of banded series to distinguish between values closes elastic#162
update displayValue type changes, fix defaulting point values from 0 to null.
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
========================================
- Coverage 98.05% 98% -0.06%
========================================
Files 39 39
Lines 2833 2853 +20
Branches 673 664 -9
========================================
+ Hits 2778 2796 +18
Misses 50 50
- Partials 5 7 +2
Continue to review full report at Codecov.
|
markov00
approved these changes
Oct 4, 2019
Collaborator
markov00
left a comment
There was a problem hiding this comment.
There are some small comments to solve before merge. Tested locally and I cannot find issues on that
nickofthyme
added a commit
that referenced
this pull request
Oct 7, 2019
This reverts commit 218402c.
nickofthyme
added a commit
that referenced
this pull request
Oct 7, 2019
nickofthyme
added a commit
to nickofthyme/elastic-charts
that referenced
this pull request
Oct 7, 2019
- Allow user to set postfix for upper and lower bound of banded series to distinguish between values sets - Update `displayValue` type changes, fix defaulting point values from 0 to null. closes elastic#162
nickofthyme
added a commit
that referenced
this pull request
Oct 7, 2019
markov00
pushed a commit
that referenced
this pull request
Oct 7, 2019
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [13.4.0](elastic/elastic-charts@v13.3.0...v13.4.0) (2019-10-07) ### Features * banded legend values ([opensearch-project#398](elastic/elastic-charts#398) & [opensearch-project#408](elastic/elastic-charts#408)) ([ca1c7ac](elastic/elastic-charts@ca1c7ac)), closes [opensearch-project#162](elastic/elastic-charts#162)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #391 (first commit comes from #391)
closes #163
Add duplicated values on the legend for banded AREA series. Legend will show upper and lower series values.
Update last values to find last values for
y0andy1Also "fixes"/removes the tooltip from showing
undefinedseriesy0values as0. Nowundefinedy0values are filtered out of the tooltip. These values will show as blanks in the legend.Screenshots
Checklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)