perf: replace spread with concat where useful#2446
Merged
markov00 merged 3 commits intoelastic:mainfrom Jun 10, 2024
Merged
Conversation
nickofthyme
approved these changes
May 30, 2024
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
Nice changes, I looked for an eslint rule to enforce these changes but nothing available 😢.
nickofthyme
pushed a commit
that referenced
this pull request
Jun 10, 2024
# [66.0.0](v65.2.0...v66.0.0) (2024-06-10) ### Features * **Metric:** style enhancements ([#2437](#2437)) ([0686596](0686596)) ### Performance Improvements * replace spread with concat where useful ([#2446](#2446)) ([078b490](078b490)) ### BREAKING CHANGES * **Metric:** The `MetricStyle.text.darkColor` and `MetricStyle.text.lightColor` are now `MetricStyle.textDarkColor` and `MetricStyle.textLightColor`, respectively. This PR also includes minor overall style changes to the text breakpoints of the `Metric` chart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replacing existing object/array spread with concat where the number of object could be high