feat(Metric): style enhancements#2437
Merged
nickofthyme merged 24 commits intoelastic:mainfrom Jun 10, 2024
Merged
Conversation
nickofthyme
commented
Jun 5, 2024
Collaborator
Author
|
buildkite update screenshots |
nickofthyme
commented
Jun 6, 2024
...llet-as-metric-vertical/bullet-as-metric/should-render-with-negative-values-chrome-linux.png
Show resolved
Hide resolved
e2e/screenshots/all.test.ts-snapshots/baselines/metric-alpha/array-of-values-chrome-linux.png
Show resolved
Hide resolved
Collaborator
Author
gvnmagni
approved these changes
Jun 10, 2024
markov00
approved these changes
Jun 10, 2024
Collaborator
markov00
left a comment
There was a problem hiding this comment.
Tested locally and works great! I'm wondering if we need to call this a breaking change, at least in charts due to the style changes
...llet-as-metric-vertical/bullet-as-metric/should-render-with-negative-values-chrome-linux.png
Show resolved
Hide resolved
nickofthyme
pushed a commit
that referenced
this pull request
Jun 10, 2024
# [66.0.0](v65.2.0...v66.0.0) (2024-06-10) ### Features * **Metric:** style enhancements ([#2437](#2437)) ([0686596](0686596)) ### Performance Improvements * replace spread with concat where useful ([#2446](#2446)) ([078b490](078b490)) ### BREAKING CHANGES * **Metric:** The `MetricStyle.text.darkColor` and `MetricStyle.text.lightColor` are now `MetricStyle.textDarkColor` and `MetricStyle.textLightColor`, respectively. This PR also includes minor overall style changes to the text breakpoints of the `Metric` chart.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the following style improvements to the
MetricSpec.BREAKING CHANGE: The
MetricStyle.text.darkColorandMetricStyle.text.lightColorare nowMetricStyle.textDarkColorandMetricStyle.textLightColor, respectively. This PR also includes minor overall style changes to the text breakpoints of theMetricchart.Demo of alignment combinations
See demo story here
Demo of auto value font sizing
Issues
closes #2306
closes #2213
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)packages/charts/src/index.ts