fix(xy): disable legend extra on ordinal#2114
Merged
markov00 merged 6 commits intoelastic:mainfrom Aug 4, 2023
Merged
Conversation
6e8e504 to
c96f0c0
Compare
Collaborator
Author
|
buildkite update screenshots |
nickofthyme
approved these changes
Aug 2, 2023
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM, just questioning why we want to add verbose notes in code.
packages/charts/src/chart_types/xy_chart/state/selectors/get_legend_item_extra_values.ts
Outdated
Show resolved
Hide resolved
nickofthyme
pushed a commit
that referenced
this pull request
Sep 20, 2023
# [60.0.0](v59.1.0...v60.0.0) (2023-09-20) ### Bug Fixes * **deps:** update dependency @elastic/eui to ^88.2.0 ([#2161](#2161)) ([6609a19](6609a19)) * **deps:** update dependency @elastic/eui to ^88.3.0 ([#2163](#2163)) ([624f43a](624f43a)) * **deps:** update dependency @elastic/eui to v85 ([#2113](#2113)) ([1b3fa7c](1b3fa7c)) * **deps:** update dependency @elastic/eui to v87 ([#2145](#2145)) ([312c32c](312c32c)) * **deps:** update dependency @elastic/eui to v88 ([#2154](#2154)) ([4070da0](4070da0)) * **tooltip:** rendering in react v18 ([#2169](#2169)) ([f30df54](f30df54)) * update font family ([#2165](#2165)) ([be07b0c](be07b0c)) * **waffle:** remove alpha artifacts ([#2139](#2139)) ([8eb4ede](8eb4ede)) * Wait a tick before reporting render status ([#2131](#2131)) ([fd2bca4](fd2bca4)) * **xy:** disable legend extra on ordinal ([#2114](#2114)) ([3ddfb18](3ddfb18)) ### Features * add locale prop to Settings ([#2164](#2164)) ([0bb3ab1](0bb3ab1)) ### BREAKING CHANGES * **xy:** when using the `ScaleType.Ordinal` for the X scale the legend extra value, representing the last and current hovered value, will not be shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR disables the legend extra value when using an ordinal scale as per #2050.
The major changes, visible also on the changes in the screenshot testing are:
currentvalue in the legend item when hovering over a chart with ordinal valuesDetails
A subsequent PR will introduce the ability to configure the legend item value
Issues
fix #2050
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)