Skip to content

feat(xy): zoom pan numerical raster and other improvements#1856

Merged
monfera merged 7 commits intoelastic:masterfrom
monfera:projection-extraction-02-squashed
Nov 2, 2022
Merged

feat(xy): zoom pan numerical raster and other improvements#1856
monfera merged 7 commits intoelastic:masterfrom
monfera:projection-extraction-02-squashed

Conversation

@monfera
Copy link
Copy Markdown
Contributor

@monfera monfera commented Oct 27, 2022

Summary

  • Instead of JFMAMJJASOND use quarterly 3-letter month names: Jan/Apr/Jul/Oct; introduce unlabelled quarterly gridlines
  • Added a zoom and pan capable continuous numerical (real) scale/axis
  • Code and type improvements to the multilayer axis (generalization etc.) and to timeslip

See the details

Details

  • feat(xy): instead of JFMAMJJASOND use quarterly 3-letter month names: Jan/Apr/Jul/Oct
  • feat(xy): introduce unlabelled quarterly gridlines
  • feat: added a zoom and pan capable continuous numerical (real) scale/axis; added a dimensionless unit "one" to BinUnit
  • feat: allow generation of nice ticks with decimal mantissa options such as 1/2/5/10 vs 1/5/10
  • refactoring(xy): make the raster generator types neutral of type eg. time (rename binStarts with intervals, TimeBin to Interval, approxWidthsInSeconds to unitIntervalWidth, timePointSec to minimum etc.)
  • chore(xy): renamed and added a bunch of docs to continuous_time_rasters.ts
  • refactoring(xy): extracted out some shareable types and functions
  • refactoring(xy): make the raster generator types have fewer properties (removed two props from AxisLayer: minimumPixelsPerSecond and approxWidthInMs)
  • refactoring(timeslip): factor out zoom_pan, config, data_fetch, animation, multitouch; smaller, fewer functions in timeslip_render
  • refactoring(timeslip): small changes eg. to rendering; introductory use of pipelined, generator/iterator functionality

Issues

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)

@monfera monfera added enhancement New feature or request :axis Axis related issue :xy Bar/Line/Area chart related :refactor Code refactor labels Oct 27, 2022
@monfera
Copy link
Copy Markdown
Contributor Author

monfera commented Oct 27, 2022

buildkite update screenshots

@monfera monfera requested a review from markov00 November 2, 2022 12:35
@monfera monfera enabled auto-merge (squash) November 2, 2022 17:02
@monfera monfera merged commit 75d826a into elastic:master Nov 2, 2022
nickofthyme pushed a commit that referenced this pull request Nov 3, 2022
# [50.1.0](v50.0.2...v50.1.0) (2022-11-03)

### Bug Fixes

* **deps:** update dependency @elastic/eui to v70 ([#1850](#1850)) ([d05994e](d05994e))

### Features

* **partition:** show hierarchical information in the tooltip ([#1843](#1843)) ([136b7ae](136b7ae))
* **xy:** quarterly time and zoom pan numerical raster as well as other improvs ([#1856](#1856)) ([75d826a](75d826a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:axis Axis related issue enhancement New feature or request :refactor Code refactor :xy Bar/Line/Area chart related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants