feat: expose all hierarchical information to the partition tooltip#1843
Merged
markov00 merged 4 commits intoelastic:masterfrom Oct 12, 2022
Merged
Conversation
Collaborator
Author
|
buildkite update screenshots |
monfera
approved these changes
Oct 12, 2022
packages/charts/src/chart_types/partition_chart/layout/viewmodel/picked_shapes.ts
Show resolved
Hide resolved
nickofthyme
pushed a commit
that referenced
this pull request
Nov 3, 2022
# [50.1.0](v50.0.2...v50.1.0) (2022-11-03) ### Bug Fixes * **deps:** update dependency @elastic/eui to v70 ([#1850](#1850)) ([d05994e](d05994e)) ### Features * **partition:** show hierarchical information in the tooltip ([#1843](#1843)) ([136b7ae](136b7ae)) * **xy:** quarterly time and zoom pan numerical raster as well as other improvs ([#1856](#1856)) ([75d826a](75d826a))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposes all the layers of a partition chart in the tooltip.
Only linear partition charts (flamegraph and icicle graph) are excluded from this behaviour, due to their possible deep hierarchy.
Details
The
percentValueGetterargument type was updated to be able to pass the variousArrayNode,ShapeTreeNodeetc that have the same concept but all of them slightly different parameters.Issues
fix #623
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)dark,light,eui-dark&eui-light