feat(xy): multilayer time axis#1430
Merged
monfera merged 31 commits intoelastic:masterfrom Oct 26, 2021
Merged
Conversation
d448a8b to
328d209
Compare
ebadfc9 to
609310d
Compare
609310d to
917ac6c
Compare
This reverts commit ccbd7c0.
3b7c5a2 to
5d6e852
Compare
Contributor
Author
|
Force pushed as the previous commit to the feature branch didn't show up in the PR and didn't start a CI run, due to some github bug |
Contributor
Author
|
And that commit still doesn't show up in the PR... |
5d6e852 to
5a4ee6c
Compare
9983e52 to
761d52f
Compare
markov00
approved these changes
Oct 26, 2021
Collaborator
markov00
left a comment
There was a problem hiding this comment.
Changes look good to me, there is no major changes on the single layer time axis so it's good to merge
nickofthyme
pushed a commit
that referenced
this pull request
Oct 26, 2021
Collaborator
|
🎉 This PR is included in version 38.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Collaborator
|
🎉 This PR is included in version 38.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation of the multilayer time axis, based on the timeslip prototype
Details
Some of the things still to do:
optionsas a quick and dirty data propagation, it should be reworkedvisible_ticks.ts(remove temp ts-ignores etc.)implementation detail: in a follow-up PR, unify the new timeslip chrono with your former timeslip chronoIssues
Closes #1310
Fixes #929
Fixes #908
Checklist
:xy,:partition):interactions,:axis):themelabel has been added and the@elastic/eui-designteam has been pinged when there areThemeAPI changescloses #123,fixes #123)packages/charts/src/index.tsdark,light,eui-dark&eui-light