feat(specs): add name to series specs#142
Merged
markov00 merged 1 commit intoelastic:masterfrom Apr 1, 2019
Merged
Conversation
A `name` prop is now available for each series. This name will be used, if available, on every legend or tooltip instead of the specId (used as fallback). fix elastic#136
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 31 31
Lines 1481 1481
Branches 163 166 +3
=======================================
Hits 1375 1375
Misses 92 92
Partials 14 14
Continue to review full report at Codecov.
|
emmacunningham
approved these changes
Apr 1, 2019
Contributor
emmacunningham
left a comment
There was a problem hiding this comment.
tested locally on Firefox & code LGTM
Collaborator
Author
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
19 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [3.5.0](elastic/elastic-charts@v3.4.5...v3.5.0) (2019-04-01) ### Bug Fixes * **areachart:** fix misaligned rendering props ([opensearch-project#141](elastic/elastic-charts#141)) ([d627f4d](elastic/elastic-charts@d627f4d)), closes [opensearch-project#140](elastic/elastic-charts#140) ### Features * **specs:** add name to series specs ([opensearch-project#142](elastic/elastic-charts#142)) ([c045eee](elastic/elastic-charts@c045eee)), closes [opensearch-project#136](elastic/elastic-charts#136)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #136
A
nameprop is now available for each series. This name will be used, if available, on everylegend or tooltip instead of the specId (used as fallback).
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.