fix(areachart): fix misaligned rendering props #141
Merged
markov00 merged 6 commits intoelastic:masterfrom Apr 1, 2019
Merged
Conversation
React Spring distributes ES6 by default, which breaks jest tests unless it's imported explicitly using the cjs extension. see pmndrs/react-spring#555
There was a misalignment between the animated props and the non animated ones that causes the area line to use the fill instead of stroke wrongly rendering the line on the chart. fix elastic#140
Aligning the props creation to area charts
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=========================================
+ Coverage 92.84% 92.9% +0.06%
=========================================
Files 31 33 +2
Lines 1481 1495 +14
Branches 163 163
=========================================
+ Hits 1375 1389 +14
Misses 92 92
Partials 14 14
Continue to review full report at Codecov.
|
84152f7 to
927d5dd
Compare
emmacunningham
approved these changes
Apr 1, 2019
Contributor
emmacunningham
left a comment
There was a problem hiding this comment.
tested localling and code LGTM
Collaborator
Author
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [3.5.0](elastic/elastic-charts@v3.4.5...v3.5.0) (2019-04-01) ### Bug Fixes * **areachart:** fix misaligned rendering props ([opensearch-project#141](elastic/elastic-charts#141)) ([d627f4d](elastic/elastic-charts@d627f4d)), closes [opensearch-project#140](elastic/elastic-charts#140) ### Features * **specs:** add name to series specs ([opensearch-project#142](elastic/elastic-charts#142)) ([c045eee](elastic/elastic-charts@c045eee)), closes [opensearch-project#136](elastic/elastic-charts#136)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #140
There was a misalignment between the animated props and the non animated ones of the area geometry that causes the area line to use the
fillinstead ofstrokewrongly filling the line on the chart.I've also moved the props creation to a single function so, at least, we have the same type of properties for animated and non animated geometries on area chart.
I've moved the props computation of bars and line outside the components.
A small change on storybook, refactoring axis ids to proper names for area chart
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.