Verify download checksums during packaging#9226
Merged
Conversation
434306e to
71c6673
Compare
71c6673 to
4b9af7d
Compare
4b9af7d to
8a9848c
Compare
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
Contributor
💚 Build Succeeded
History
cc @swiatekm |
michel-laterman
approved these changes
Aug 22, 2025
Contributor
michel-laterman
left a comment
There was a problem hiding this comment.
LGTM was able to verify that this verifies files in successful build cases.
michalpristas
approved these changes
Aug 25, 2025
Contributor
|
@Mergifyio backport 8.17 8.18 8.19 9.0 9.1 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Verify download checksums * Add tests for checksum verification (cherry picked from commit d5d0175)
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Verify download checksums * Add tests for checksum verification (cherry picked from commit d5d0175)
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Verify download checksums * Add tests for checksum verification (cherry picked from commit d5d0175)
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Verify download checksums * Add tests for checksum verification (cherry picked from commit d5d0175)
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Verify download checksums * Add tests for checksum verification (cherry picked from commit d5d0175)
4 tasks
swiatekm
added a commit
that referenced
this pull request
Aug 25, 2025
swiatekm
added a commit
that referenced
this pull request
Aug 25, 2025
swiatekm
added a commit
that referenced
this pull request
Aug 25, 2025
swiatekm
added a commit
that referenced
this pull request
Aug 25, 2025
swiatekm
added a commit
that referenced
this pull request
Aug 25, 2025
kaanyalti
pushed a commit
to kaanyalti/elastic-agent
that referenced
this pull request
Sep 4, 2025
* Verify download checksums * Add tests for checksum verification
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It verifies downloaded binaries using checksum files that we already download anyway.
Why is it important?
We ensure we don't accidentally package corrupted binaries.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
Package agent locally. Intentionally corrupting the download requires some fiddling with proxies, unfortunately.