Skip to content

[9.1] (backport #9226) Verify download checksums during packaging#9559

Merged
swiatekm merged 1 commit into9.1from
mergify/bp/9.1/pr-9226
Aug 25, 2025
Merged

[9.1] (backport #9226) Verify download checksums during packaging#9559
swiatekm merged 1 commit into9.1from
mergify/bp/9.1/pr-9226

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Aug 25, 2025

What does this PR do?

It verifies downloaded binaries using checksum files that we already download anyway.

Why is it important?

We ensure we don't accidentally package corrupted binaries.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

How to test this PR locally

Package agent locally. Intentionally corrupting the download requires some fiddling with proxies, unfortunately.


This is an automatic backport of pull request #9226 done by [Mergify](https://mergify.com).

* Verify download checksums

* Add tests for checksum verification

(cherry picked from commit d5d0175)
@mergify mergify bot added the backport label Aug 25, 2025
@mergify mergify bot requested a review from a team as a code owner August 25, 2025 10:42
@mergify mergify bot requested review from kaanyalti and michel-laterman and removed request for a team August 25, 2025 10:42
@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog chore Tasks that just need to be done, they are neither bug, nor enhancements labels Aug 25, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elastic-sonarqube
Copy link
Copy Markdown

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

cc @swiatekm

@swiatekm swiatekm merged commit ca4f5c3 into 9.1 Aug 25, 2025
21 checks passed
@swiatekm swiatekm deleted the mergify/bp/9.1/pr-9226 branch August 25, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport chore Tasks that just need to be done, they are neither bug, nor enhancements skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants