Skip to content

Removed call to fleet setup during container start#2985

Merged
michalpristas merged 2 commits intoelastic:mainfrom
michalpristas:fix/remove-setup
Jul 4, 2023
Merged

Removed call to fleet setup during container start#2985
michalpristas merged 2 commits intoelastic:mainfrom
michalpristas:fix/remove-setup

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented Jul 4, 2023

As setup is now called in kibana we don't need to call it at all.
PR removes these calls and ENV variable altering behavior.

Tested:

  • enroll modified agent to normal fleet
  • enroll modified agent on k8s to normal fleet
  • enroll modified agent to cloud instance running modified agent (using cloud first testing)

All working

Fixes: #2910

@michalpristas michalpristas added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team backport-skip skip-changelog labels Jul 4, 2023
@michalpristas michalpristas self-assigned this Jul 4, 2023
@michalpristas michalpristas requested a review from a team as a code owner July 4, 2023 11:01
@michalpristas michalpristas requested review from AndersonQ and pchila July 4, 2023 11:01
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 4, 2023

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 4, 2023

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 4, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-04T11:19:04.394+0000

  • Duration: 23 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 5935
Skipped 23
Total 5958

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 4, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.684% (75/76) 👍
Files 68.582% (179/261) 👍
Classes 66.94% (326/487) 👍
Methods 54.112% (1033/1909) 👍 0.057
Lines 40.302% (11860/29428) 👍 0.038
Conditionals 100.0% (0/0) 💚

pchila
pchila approved these changes Jul 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalpristas michalpristas merged commit e2ba58a into elastic:main Jul 4, 2023
@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Jul 5, 2023

This is missing a changelog fragment :p

@pierrehilbert
Copy link
Copy Markdown
Contributor

pierrehilbert commented Jul 5, 2023

@michalpristas could you please correct this and add it when you will be back?

@michalpristas
Copy link
Copy Markdown
Contributor Author

michalpristas commented Jul 7, 2023

changelog fragment: #3035

AndersonQ pushed a commit to AndersonQ/elastic-agent that referenced this pull request Jul 10, 2023
@michalpristas @AndersonQ
Removed call to fleet setup during container start (elastic#2985)
b07e503
@linghengqian linghengqian mentioned this pull request Jan 8, 2026
Closed
@vishaangelova vishaangelova mentioned this pull request Feb 9, 2026
Merged
2 tasks
vishaangelova added a commit to elastic/docs-content that referenced this pull request Feb 11, 2026
@vishaangelova
Remove references to the KIBANA_FLEET_SETUP env variable (#5061)
7a4a68b 
## Summary

This PR removes remaining references to the deleted `KIBANA_FLEET_SETUP`
env variable (see elastic/elastic-agent#2985 and
elastic/ingest-docs#1354).

Resolves #4546

## Generative AI disclosure

1. Did you use a generative AI (GenAI) tool to assist in creating this
contribution?
- [ ] Yes  
- [X] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pchila pchila pchila approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@michalpristas michalpristas

Labels

backport-skip skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove KibanaSetup call as it is not needed anymore

5 participants

@michalpristas @elasticmachine @cmacknz @pierrehilbert @pchila