This repository was archived by the owner on Sep 17, 2024. It is now read-only.
chore: refactor cucumber tags#2496
Merged
mdelapenya merged 11 commits intoelastic:mainfrom May 9, 2022
Merged
Conversation
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2022
* chore: rename endpoint integration scenarios * chore: indent * chore: rename tag for fleet_mode * chore: rename install to add integration * chore: remove misleading tag * chore: simplify tags for permission output change * chore: indent * fix: remove duplicated scenario for running on beats * chore: rename to stand-alone mode * chore: proper feature file description * chore: simplify tags for system integration (cherry picked from commit 878a99d)
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2022
* chore: rename endpoint integration scenarios * chore: indent * chore: rename tag for fleet_mode * chore: rename install to add integration * chore: remove misleading tag * chore: simplify tags for permission output change * chore: indent * fix: remove duplicated scenario for running on beats * chore: rename to stand-alone mode * chore: proper feature file description * chore: simplify tags for system integration (cherry picked from commit 878a99d)
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2022
* chore: rename endpoint integration scenarios * chore: indent * chore: rename tag for fleet_mode * chore: rename install to add integration * chore: remove misleading tag * chore: simplify tags for permission output change * chore: indent * fix: remove duplicated scenario for running on beats * chore: rename to stand-alone mode * chore: proper feature file description * chore: simplify tags for system integration (cherry picked from commit 878a99d)
mdelapenya
added a commit
that referenced
this pull request
May 9, 2022
* chore: rename endpoint integration scenarios * chore: indent * chore: rename tag for fleet_mode * chore: rename install to add integration * chore: remove misleading tag * chore: simplify tags for permission output change * chore: indent * fix: remove duplicated scenario for running on beats * chore: rename to stand-alone mode * chore: proper feature file description * chore: simplify tags for system integration (cherry picked from commit 878a99d) Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
added a commit
that referenced
this pull request
May 9, 2022
* chore: rename endpoint integration scenarios * chore: indent * chore: rename tag for fleet_mode * chore: rename install to add integration * chore: remove misleading tag * chore: simplify tags for permission output change * chore: indent * fix: remove duplicated scenario for running on beats * chore: rename to stand-alone mode * chore: proper feature file description * chore: simplify tags for system integration (cherry picked from commit 878a99d) Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
added a commit
that referenced
this pull request
May 9, 2022
* chore: rename endpoint integration scenarios * chore: indent * chore: rename tag for fleet_mode * chore: rename install to add integration * chore: remove misleading tag * chore: simplify tags for permission output change * chore: indent * fix: remove duplicated scenario for running on beats * chore: rename to stand-alone mode * chore: proper feature file description * chore: simplify tags for system integration (cherry picked from commit 878a99d) Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
May 10, 2022
* main: bump stack version 8.3.0-d380914f (elastic#2505) chore: refactor cucumber tags (elastic#2496) chore: skip system-integration scenarios for Beats (elastic#2482)
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
May 10, 2022
* main: bump stack version 8.3.0-d380914f (elastic#2505) chore: refactor cucumber tags (elastic#2496) chore: skip system-integration scenarios for Beats (elastic#2482)
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
May 22, 2022
* main: bump stack version 8.3.0-8ee1196f (elastic#2519) ci: daily pipeline to use main branch (elastic#2516) bump stack version 8.3.0-53513548 (elastic#2513) chore: run reaper daily at 1:30 am (elastic#2512) avoid aliases if no major.minor format (elastic#2501) bump stack version 8.3.0-d380914f (elastic#2505) chore: refactor cucumber tags (elastic#2496) chore: skip system-integration scenarios for Beats (elastic#2482) bump stack version 8.3.0-5c1ff35f (elastic#2494) chore: reduce AWS instances size (elastic#2477) chore: wait for the stack while provisioning (elastic#2486) bump stack version 8.3.0-6ba9f710 (elastic#2484)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It refactors the tag names in the cucumber feature files, for the following reasons: clarity, align with the intention of the scenario, and simplicity.
During this process, we detected the duplication of two examples in one scenario, causing it to be executed 4 times instead of 2.
Why is it important?
KISS
Checklist
make unit-test), and they are passing locallymake noticein the proper directory)Related issues