Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

chore: skip system-integration scenarios for Beats#2482

Merged
mdelapenya merged 3 commits intoelastic:mainfrom
mdelapenya:skip-system-integration-from-beats
May 9, 2022
Merged

chore: skip system-integration scenarios for Beats#2482
mdelapenya merged 3 commits intoelastic:mainfrom
mdelapenya:skip-system-integration-from-beats

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

  • chore: copy default profile for beats
  • chore: remove system integrations tests for Beats

What does this PR do?

It copies the default profile for running the e2e tests, removing the system-integration tests, as they are adding certain flakiness

Why is it important?

Having a more stable test execution is critical for team success, and the system integration test suite is behaving with certain flakiness, which the product team is currently investigating.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests (make unit-test), and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

@mdelapenya mdelapenya added Team:Automation Label for the Observability productivity team area:ci Anything related to the CI backport-v7.17.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify requested-by:Obs-DC labels May 5, 2022
@mdelapenya mdelapenya self-assigned this May 5, 2022
@mdelapenya mdelapenya requested review from a team, cmacknz and v1v May 5, 2022 14:48
- name: "Linux Integration"
tags: "linux_integration"
platforms: ["debian_arm64", "debian_amd64", "sles15"]
# - name: "Permissions Output change"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look to be commented out everywhere, can they just be deleted?

- name: "Metricbeat"
tags: "metricbeat"
platforms: ["debian_amd64"]
- suite: "fleet"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the base for this from https://github.com/elastic/e2e-testing/blob/main/.ci/.e2e-tests.yaml?

Can we maybe reference that file in a comment here, and note what the differences are and why?

Copy link
Copy Markdown
Contributor Author

@mdelapenya mdelapenya May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the differences, I'd like the product team to be the ones to define what to run when beats triggers the e2e for Fleet. I could see it defining different profiles: for kubernetes autodiscover, metricbeat, filebeat, etc, and with them, slect one or the other profile from beats when a a condition is met in the Beats pipeline (modified files?)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I do expect us to be maintaining this after the initial commit.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-09T11:17:07.382+0000

  • Duration: 65 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 315
Skipped 0
Total 315

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mdelapenya mdelapenya merged commit 33ea115 into elastic:main May 9, 2022
mergify bot pushed a commit that referenced this pull request May 9, 2022
* chore: copy default profile for beats

* chore: remove system integrations tests for Beats

* chore: remove comments

(cherry picked from commit 33ea115)
mergify bot pushed a commit that referenced this pull request May 9, 2022
* chore: copy default profile for beats

* chore: remove system integrations tests for Beats

* chore: remove comments

(cherry picked from commit 33ea115)
mergify bot pushed a commit that referenced this pull request May 9, 2022
* chore: copy default profile for beats

* chore: remove system integrations tests for Beats

* chore: remove comments

(cherry picked from commit 33ea115)
mdelapenya added a commit that referenced this pull request May 9, 2022
* chore: copy default profile for beats

* chore: remove system integrations tests for Beats

* chore: remove comments

(cherry picked from commit 33ea115)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit that referenced this pull request May 9, 2022
* chore: copy default profile for beats

* chore: remove system integrations tests for Beats

* chore: remove comments

(cherry picked from commit 33ea115)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit that referenced this pull request May 9, 2022
* chore: copy default profile for beats

* chore: remove system integrations tests for Beats

* chore: remove comments

(cherry picked from commit 33ea115)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request May 10, 2022
* main:
  bump stack version 8.3.0-d380914f (elastic#2505)
  chore: refactor cucumber tags (elastic#2496)
  chore: skip system-integration scenarios for Beats (elastic#2482)
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request May 10, 2022
* main:
  bump stack version 8.3.0-d380914f (elastic#2505)
  chore: refactor cucumber tags (elastic#2496)
  chore: skip system-integration scenarios for Beats (elastic#2482)
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request May 22, 2022
* main:
  bump stack version 8.3.0-8ee1196f (elastic#2519)
  ci: daily pipeline to use main branch (elastic#2516)
  bump stack version 8.3.0-53513548 (elastic#2513)
  chore: run reaper daily at 1:30 am (elastic#2512)
  avoid aliases if no major.minor format (elastic#2501)
  bump stack version 8.3.0-d380914f (elastic#2505)
  chore: refactor cucumber tags (elastic#2496)
  chore: skip system-integration scenarios for Beats (elastic#2482)
  bump stack version 8.3.0-5c1ff35f (elastic#2494)
  chore: reduce AWS instances size (elastic#2477)
  chore: wait for the stack while provisioning (elastic#2486)
  bump stack version 8.3.0-6ba9f710 (elastic#2484)
@mdelapenya mdelapenya deleted the skip-system-integration-from-beats branch July 13, 2022 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area:ci Anything related to the CI backport-v7.17.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify requested-by:Obs-DC Team:Automation Label for the Observability productivity team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants