Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

Feat installer rework 2#1208

Merged
adam-stokes merged 3 commits intomasterfrom
feat-installer-rework-2
May 30, 2021
Merged

Feat installer rework 2#1208
adam-stokes merged 3 commits intomasterfrom
feat-installer-rework-2

Conversation

@adam-stokes
Copy link
Copy Markdown
Contributor

@adam-stokes adam-stokes commented May 26, 2021

Continuation of #1163

Fixes #1200

This was tested against both debian/centos using the same scripts from .ci/

Supports installing services no matter the deployment backend. Also support
installation methods for tar, rpm, deb and easily extensible to exe/dmg for mac
and windows.

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
@adam-stokes adam-stokes requested a review from mdelapenya May 26, 2021 16:06
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 26, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: adam-stokes commented: jenkins run the tests please

  • Start Time: 2021-05-26T16:27:24.614+0000

  • Duration: 19 min 48 sec

  • Commit: 27651f8

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 0
Total 160

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 0
Total 160

@adam-stokes
Copy link
Copy Markdown
Contributor Author

Same flaky test failure as before

@adam-stokes
Copy link
Copy Markdown
Contributor Author

adam-stokes commented May 26, 2021

jenkins run the tests please

@adam-stokes adam-stokes marked this pull request as ready for review May 26, 2021 16:57
Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-stokes I've tested this PR with different combinations, including Debian and Ubi8 images:

current snapshot

TAGS="backend_processes" TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE BEATS_USE_CI_SNAPSHOT=false DEVELOPER_MODE=true make -C e2e/_suites/fleet functional-test

TAGS="stand_alone_agent" TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE BEATS_USE_CI_SNAPSHOT=false DEVELOPER_MODE=true make -C e2e/_suites/fleet functional-test

TAGS="agent_endpoint_integration" TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE BEATS_USE_CI_SNAPSHOT=false DEVELOPER_MODE=true make -C e2e/_suites/fleet functional-test

Beats CI snapshot for cec5906b013f4a99b29614509ac44d7e3e75dfe0

The cec5906b013f4a99b29614509ac44d7e3e75dfe0 commit represents the master branch in Beats:

TAGS="backend_processes" TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE BEATS_USE_CI_SNAPSHOT=true GITHUB_CHECK_SHA1=cec5906b013f4a99b29614509ac44d7e3e75dfe0 DEVELOPER_MODE=true make -C e2e/_suites/fleet functional-test

TAGS="stand_alone_agent" TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE BEATS_USE_CI_SNAPSHOT=true GITHUB_CHECK_SHA1=cec5906b013f4a99b29614509ac44d7e3e75dfe0 DEVELOPER_MODE=true make -C e2e/_suites/fleet functional-test

TAGS="agent_endpoint_integration" TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE BEATS_USE_CI_SNAPSHOT=true GITHUB_CHECK_SHA1=cec5906b013f4a99b29614509ac44d7e3e75dfe0 DEVELOPER_MODE=true make -C e2e/_suites/fleet functional-test

LGTM 👍

image

@adam-stokes adam-stokes merged commit f043003 into master May 30, 2021
mergify bot pushed a commit that referenced this pull request May 30, 2021
* Installer refactor

Supports installing services no matter the deployment backend. Also support
installation methods for tar, rpm, deb and easily extensible to exe/dmg for mac
and windows.

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>

* Fixes #1200

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>

* Cleanup dead code

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
(cherry picked from commit f043003)
mergify bot pushed a commit that referenced this pull request May 30, 2021
* Installer refactor

Supports installing services no matter the deployment backend. Also support
installation methods for tar, rpm, deb and easily extensible to exe/dmg for mac
and windows.

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>

* Fixes #1200

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>

* Cleanup dead code

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
(cherry picked from commit f043003)

# Conflicts:
#	e2e/_suites/fleet/fleet.go
#	internal/common/defaults.go
#	internal/installer/base.go
#	internal/installer/deb.go
#	internal/installer/docker.go
#	internal/installer/elasticagent.go
#	internal/installer/rpm.go
#	internal/installer/tar.go
@mergify mergify bot deleted the feat-installer-rework-2 branch May 30, 2021 22:50
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Jun 1, 2021
* master:
  Feat installer rework 2 (elastic#1208)
mdelapenya added a commit that referenced this pull request Jun 1, 2021
* Installer refactor

Supports installing services no matter the deployment backend. Also support
installation methods for tar, rpm, deb and easily extensible to exe/dmg for mac
and windows.

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>

* Fixes #1200

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>

* Cleanup dead code

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
(cherry picked from commit f043003)

Co-authored-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit that referenced this pull request Jun 1, 2021
* Feat installer rework 2 (#1208)

* Installer refactor

Supports installing services no matter the deployment backend. Also support
installation methods for tar, rpm, deb and easily extensible to exe/dmg for mac
and windows.

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>

* Fixes #1200

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>

* Cleanup dead code

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
(cherry picked from commit f043003)

# Conflicts:
#	e2e/_suites/fleet/fleet.go
#	internal/common/defaults.go
#	internal/installer/base.go
#	internal/installer/deb.go
#	internal/installer/docker.go
#	internal/installer/elasticagent.go
#	internal/installer/rpm.go
#	internal/installer/tar.go

* fix: resolve conflicts

Co-authored-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debian installer is broken

3 participants