This repository was archived by the owner on Sep 17, 2024. It is now read-only.
Update installer code to support deployer abstraction#1163
Merged
adam-stokes merged 14 commits intomasterfrom May 25, 2021
Merged
Update installer code to support deployer abstraction#1163adam-stokes merged 14 commits intomasterfrom
adam-stokes merged 14 commits intomasterfrom
Conversation
Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
…g into feat-installer-rework
Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
Contributor
Author
|
@mdelapenya have a look at this PR as it shows how we can abstract out a 'Package' and support the different installation/configuration methods. This also fixes the installer interface as the previous one wasn't adhering to the interface |
mdelapenya
reviewed
May 13, 2021
mdelapenya
reviewed
May 13, 2021
mdelapenya
reviewed
May 13, 2021
mdelapenya
reviewed
May 13, 2021
mdelapenya
reviewed
May 13, 2021
mdelapenya
reviewed
May 13, 2021
mdelapenya
reviewed
May 13, 2021
Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
reviewed
May 13, 2021
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
Contributor
Author
|
@mdelapenya I needed to rework the installer code to support attaching to a deployment. Similar to the way |
Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
mdelapenya
reviewed
May 20, 2021
Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
mdelapenya
reviewed
May 24, 2021
mdelapenya
reviewed
May 24, 2021
Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
cachedout
approved these changes
May 25, 2021
mdelapenya
approved these changes
May 25, 2021
Contributor
mdelapenya
left a comment
There was a problem hiding this comment.
I've verified that Beats PR are covered by this PR, so LGTM
How to test a Beats PR:
# needed to get artifacts from GCP bucket
export BEATS_USE_CI_SNAPSHOTS=true
# git sha1 for a commit in the proper maintenance branch
export GITHUB_CHECK_SHA1=b989478a3003c1b41722b7245586d58d832748a4
SUITE="fleet" TAGS="stand_alone_agent" TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE DEVELOPER_MODE=true \
make -C e2e functional-testThinking about adding this to the PR template ⬆️⬆️
Contributor
Author
Yea we should add that to the template for sure |
mergify bot
pushed a commit
that referenced
this pull request
May 25, 2021
* Installer refactor * More work abstracting out installer bits * Update internal/deploy/docker.go * Update installer to support attaching a deployment * cleanup execing into services * fix e2e tests * print logs of container, up timeout factor * revert jenkinsfile * remove dead code Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> (cherry picked from commit 584769a)
mergify bot
pushed a commit
that referenced
this pull request
May 25, 2021
* Installer refactor * More work abstracting out installer bits * Update internal/deploy/docker.go * Update installer to support attaching a deployment * cleanup execing into services * fix e2e tests * print logs of container, up timeout factor * revert jenkinsfile * remove dead code Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> (cherry picked from commit 584769a) # Conflicts: # e2e/_suites/fleet/fleet.go # internal/installer/base.go # internal/installer/deb.go # internal/installer/rpm.go # internal/installer/tar.go
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
May 25, 2021
* master: Update installer code to support deployer abstraction (elastic#1163)
adam-stokes
added a commit
that referenced
this pull request
May 25, 2021
* Installer refactor * More work abstracting out installer bits * Update internal/deploy/docker.go * Update installer to support attaching a deployment * cleanup execing into services * fix e2e tests * print logs of container, up timeout factor * revert jenkinsfile * remove dead code Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> (cherry picked from commit 584769a) Co-authored-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
8 tasks
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
May 26, 2021
…c#1163) (elastic#1198)" This reverts commit d5689c7.
mdelapenya
added a commit
that referenced
this pull request
May 26, 2021
mdelapenya
added a commit
that referenced
this pull request
May 26, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
May 26, 2021
* master: Revert "Update installer code to support deployer abstraction (elastic#1163)" (elastic#1201) Update installer code to support deployer abstraction (elastic#1163)
This was referenced May 26, 2021
Closed
Closed
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the installer code to utilize the deployment backend mechanics
Why is it important?
This allows us to greatly increase the support of testing against various deployments (local host only, docker, kubernetes) and abstracts out the code necessary to install and run the elastic-agent on those providers
Checklist
make noticein the proper directory)