Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

Revert "Update installer code to support deployer abstraction (#1163) (#1198)"#1202

Merged
mdelapenya merged 1 commit intoelastic:7.xfrom
mdelapenya:7.x-revert-debian-installer
May 26, 2021
Merged

Revert "Update installer code to support deployer abstraction (#1163) (#1198)"#1202
mdelapenya merged 1 commit intoelastic:7.xfrom
mdelapenya:7.x-revert-debian-installer

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya commented May 26, 2021 •
edited
Loading

This reverts commit d5689c7.

What does this PR do?

It reverts #1198 until we fix the debian installer (I'd say any installer other than docker)

Why is it important?

Debian tests are broken, as described in #1200

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@mdelapenya mdelapenya self-assigned this May 26, 2021
@mdelapenya mdelapenya requested a review from a team May 26, 2021 06:24
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 26, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1202 opened

  • Start Time: 2021-05-26T06:24:31.754+0000

  • Duration: 20 min 44 sec

  • Commit: 80d43ae

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 0
Total 160

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 0
Total 160

@mdelapenya mdelapenya marked this pull request as ready for review May 26, 2021 08:11
@mdelapenya mdelapenya merged commit a6c8bab into elastic:7.x May 26, 2021
@mdelapenya mdelapenya deleted the 7.x-revert-debian-installer branch May 26, 2021 09:25
@mdelapenya mdelapenya mentioned this pull request Oct 26, 2021
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@cachedout cachedout cachedout approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdelapenya mdelapenya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdelapenya @elasticmachine @cachedout @kuisathaverat