This repository was archived by the owner on Sep 17, 2024. It is now read-only.
chore: abstract image pulling#1137
Merged
adam-stokes merged 1 commit intoelastic:masterfrom May 5, 2021
Merged
Conversation
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
v1v
approved these changes
May 5, 2021
mergify bot
pushed a commit
that referenced
this pull request
May 5, 2021
(cherry picked from commit 4c0075f) # Conflicts: # e2e/_suites/fleet/ingest_manager_test.go # internal/docker/docker.go
mergify bot
pushed a commit
that referenced
this pull request
May 5, 2021
(cherry picked from commit 4c0075f) # Conflicts: # e2e/_suites/fleet/ingest_manager_test.go # internal/docker/docker.go
mdelapenya
added a commit
that referenced
this pull request
May 6, 2021
mdelapenya
added a commit
that referenced
this pull request
May 6, 2021
mdelapenya
added a commit
that referenced
this pull request
May 6, 2021
mdelapenya
added a commit
that referenced
this pull request
May 6, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
May 6, 2021
* master: chore: update mergify's titles (elastic#1142) chore: remove unused pipelines (elastic#1143) feat: use Docker copy to transfer binaries to containers (elastic#1136) chore: abstract image pulling (elastic#1137) Support multiple deployment backends (elastic#1130) chore: remove unused code (elastic#1119) Unify fleet and stand-alone suites (elastic#1112) Pull fresh docker images before suite (elastic#1123) chore: initialise timeout factor next to the declaration (elastic#1118) chore: match Go version with Beats (elastic#1120) feat: support running k8s autodiscover suite for Beats PRs and local repositories (elastic#1115) Auto bootstrap fleet during initialize scenario (elastic#1116) Kubernetes Deployment (elastic#1110)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It abstract the pull images method so that the consumer is passing what images to pull
Why is it important?
To make the pull method reusable by other test suites.
Checklist
make noticein the proper directory)Related issues