Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

fix: use proper variable name#1102

Merged
mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya:fix-pipeline-param
Apr 27, 2021
Merged

fix: use proper variable name#1102
mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya:fix-pipeline-param

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes the variable name for the vault secret, as it was a wrong copy&paste.

Why is it important?

Following same patterns is important: i used DOCKER_REGISTRY* as namespace, but copied from other pipeline its usage :/

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

@mdelapenya mdelapenya self-assigned this Apr 27, 2021
@mdelapenya mdelapenya requested a review from a team April 27, 2021 15:34
@mdelapenya mdelapenya marked this pull request as ready for review April 27, 2021 15:34
@mdelapenya mdelapenya merged commit 6873757 into elastic:master Apr 27, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1102 opened

  • Start Time: 2021-04-27T15:34:28.267+0000

  • Duration: 37 min 41 sec

  • Commit: 7d54414

Test stats 🧪

Test Results
Failed 0
Passed 153
Skipped 0
Total 153

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 153
Skipped 0
Total 153

mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Apr 27, 2021
* master:
  Support fleet-server-service-token (elastic#1096)
  fix: use wider selector for ARM workers (elastic#1103)
  feat: bootstrap fleet-server for the deployment of regular elastic-agents (elastic#1078)
  fix: use proper variable name (elastic#1102)
  fix: branch_specifier is needed (elastic#1097)
  Move kubernetes/kubectl/kind code to internal project layout (elastic#1092)
  fix: update JJBB with proper values (elastic#1093)
  feat: support building centos/debian Docker images in multiplatform format (elastic#1091)
  Kubernetes autodiscover suite (elastic#1064)
@mdelapenya mdelapenya deleted the fix-pipeline-param branch April 30, 2021 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants