Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

Support fleet-server-service-token during bootstrap#1096

Merged
adam-stokes merged 2 commits intomasterfrom
fix-1079
Apr 27, 2021
Merged

Support fleet-server-service-token during bootstrap#1096
adam-stokes merged 2 commits intomasterfrom
fix-1079

Conversation

@adam-stokes
Copy link
Copy Markdown
Contributor

Replaces the username/password bootstrap with a fleet service token

Signed-off-by: Adam Stokes 51892+adam-stokes@users.noreply.github.com

What does this PR do?

This PR replaces the previous way we were authenticating with elasticsearch during the fleet server bootstrap. The recommended way is to not use username/password and instead use a service token. This PR updates that functionality to utilize the recommend approach.

Why is it important?

It is stated that eventually fleet server service tokens will be the only way going forward to authenticate during bootstrap.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

  • [ ]

How to test this PR locally

make -C e2e functional-test

Related issues

Replaces the username/password bootstrap with a fleet service token

Signed-off-by: Adam Stokes <51892+adam-stokes@users.noreply.github.com>
@adam-stokes adam-stokes requested review from a team, blakerouse and ph April 26, 2021 19:27
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 26, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1096 updated

  • Start Time: 2021-04-27T18:03:16.778+0000

  • Duration: 40 min 40 sec

  • Commit: 579b6cf

Test stats 🧪

Test Results
Failed 0
Passed 89
Skipped 0
Total 89

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 89
Skipped 0
Total 89

@mdelapenya
Copy link
Copy Markdown
Contributor

Let's merge #1078 first, so that all scenarios use fleet server.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 27, 2021

This pull request is now in conflict. Could you fix it @adam-stokes? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-1079 upstream/fix-1079
git merge upstream/master
git push upstream fix-1079

@adam-stokes adam-stokes merged commit 4ece966 into master Apr 27, 2021
@adam-stokes adam-stokes deleted the fix-1079 branch April 27, 2021 18:45
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Apr 27, 2021
* master:
  Support fleet-server-service-token (elastic#1096)
  fix: use wider selector for ARM workers (elastic#1103)
  feat: bootstrap fleet-server for the deployment of regular elastic-agents (elastic#1078)
  fix: use proper variable name (elastic#1102)
  fix: branch_specifier is needed (elastic#1097)
  Move kubernetes/kubectl/kind code to internal project layout (elastic#1092)
  fix: update JJBB with proper values (elastic#1093)
  feat: support building centos/debian Docker images in multiplatform format (elastic#1091)
  Kubernetes autodiscover suite (elastic#1064)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support fleet service tokens for interacting with fleet server

4 participants