Add option to support moved filebeat modules#9432
Merged
jsoriano merged 7 commits intoelastic:masterfrom Dec 21, 2018
Merged
Conversation
Contributor
|
Pinging @elastic/infrastructure |
If a module needs to be moved, existing configuration will stop working, this change adds an option to mark an old module as moved to other name. This is being considered for the movement of apache2 module to apache to be coherent with metricbeat module (elastic#9402).
be2f921 to
30bc249
Compare
ruflin
reviewed
Dec 7, 2018
Contributor
ruflin
left a comment
There was a problem hiding this comment.
Could you add some tests to this PR? Not sure yet what the best way would be here.
Member
Author
|
Test added with a dummy modules directory for this case. |
Contributor
|
jenkins, test this |
ruflin
approved these changes
Dec 12, 2018
jsoriano
added a commit
that referenced
this pull request
Jan 12, 2019
Rename filebeat `apache2` module to `apache`. `apache2` module is kept as a "moved" module (#9432) so existing configurations continue working. Aliases for renamed fields are added and they will be handled as fields renamed for ECS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a module needs to be moved, existing configuration will stop working,
this change adds an option to mark an old module as moved to other name.
This is being considered for the movement of apache2 module to apache to
be coherent with metricbeat module (#9402).
So if the
module.ymlfile of the apache2 module contains:Every time the
apache2module is used a warning is printed about thechange and
apachemodule is used instead.