Rename filebeat apache2 module to apache#9402
Conversation
34beeb1 to
4081e91
Compare
ruflin
left a comment
There was a problem hiding this comment.
Before merging this we need to think through on what our expected upgrade path here is. What happens if users upgrade from 6.x to 7.x.
dev-tools/ecs-migration.yml
Outdated
There was a problem hiding this comment.
So this becomes now interesting. This is for compatibility with 6.x. In 6.x it will stay apache2. Now comes the tricky part: We will have a mix of apache2 and apache fields. What should we do?
There was a problem hiding this comment.
Not only the fields, but also configurations referring to both names should work during at least some versions (6.7?).
Shall we duplicate the module during some versions?
There was a problem hiding this comment.
@ruflin easier, I have reverted the changes in the ECS migration, and I have added aliases for the rest of fields, so we use the same strategy than for ECS.
There was a problem hiding this comment.
For config migration I am still not sure how to do it.
|
Pinging @elastic/infrastructure |
a2b0ef4 to
be2f162
Compare
If a module needs to be moved, existing configuration will stop working, this change adds an option to mark an old module as moved to other name. This is being considered for the movement of apache2 module to apache to be coherent with metricbeat module (elastic#9402).
| @@ -26,6 +26,7 @@ import ( | |||
| "strings" | |||
There was a problem hiding this comment.
Changes on this file if done will be done in #9432.
|
I had a chat with @jsoriano about the migration from 6.x to 7.x and it should be working the same ways as for any other module based on the proposal here. |
|
PR #8963 should be merged first to reduce the surface of this change. |
If a module needs to be moved, existing configuration will stop working, this change adds an option to mark an old module as moved to other name. This is being considered for the movement of apache2 module to apache to be coherent with metricbeat module (#9402).
8ea885d to
6cc43a1
Compare
|
@ruflin this would be mostly ready, my main doubt is what to do with dashboards, not sure if I should rename fields there. |
|
@jsoriano Yes, aggregations support aliases, and all visualizations are built on that. The only part that aliases don't help us with, in the Kibana Objects, is the saved searches. The saved search columns are _source field names. Aliases don't apply to _source at all. |
|
What we currently have is that if someone upgrades from 6.x to 7.x, he keeps his old dashboards from 6.x and enables the migration layer. As we have added all alias for the apache2 fields, things should keep working as is. For dashboards etc. I'm in the progress of writing a migration scripts based on the ecs-migration.yml file. I just realised now that this is missing in this PR and should be added to make sure we rename the fields correctly. Potentially it just needs update to point to the "apache" instead of "apache2" fields. |
| description: > | ||
| Contains fields for the Apache HTTP Server access logs. | ||
| fields: | ||
| - name: remote_ip |
There was a problem hiding this comment.
@webmat We should follow up on this and convert it to ECS.
There was a problem hiding this comment.
Yes, I have a note at the end of the Fb modules list (in #8655) to convert to using .address in all remaining places (it was a beta 2 addition, and came from the first migrations, like this one)
|
Ok, I am merging this, and lets polish when all pieces are in place. Thanks for the feedback and reviews! |
The modules for Apache HTTP Server are called
apachein metricbeatand
apache2in filebeat. Use the same name for both modules.Fixes #9395.