Merged
Conversation
Contributor
|
Pinging @elastic/uptime |
ruflin
reviewed
Dec 6, 2018
Contributor
ruflin
left a comment
There was a problem hiding this comment.
LGTM. Needs a changelog entry.
ruflin
reviewed
Dec 10, 2018
Contributor
|
I sugget we do different PR's for the different fields which should be mapped to ECS. Could you open a meta Github issue to track the fields that need change? |
d240831 to
bb73109
Compare
Contributor
Author
|
@ruflin just removed the extra commit for Am I good to merge? (was the previously LGTM approval enough BTW?). |
ruflin
approved these changes
Dec 12, 2018
Contributor
Author
|
jenkins, retest this please (build timed out waiting for an OSX box to become available) |
ba3d1ab to
4f3e0fd
Compare
Contributor
|
The two tests / builds that were failing here can be ignored. I'm already working on fixing them / making them more stable. |
Contributor
|
If you want a green CI, try to rebase as tests should now be fixed in master. Mac builds will still be slow. |
0e16448 to
9a9e12e
Compare
9a9e12e to
9e62892
Compare
Contributor
Author
|
jenkins, retest this please |
This brings us closer to ECS compliance by adding the event.dataset field. All heartbeat events are considered part of the 'uptime' dataset, even though their data may differ. The key thing defining this dataset is the presence of the `monitor.status` field
9e62892 to
551b5ba
Compare
Contributor
|
@andrewvc Still good to go. Ignore the failures please. |
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Dec 14, 2018
This brings us closer to ECS compliance by adding the event.dataset field. All heartbeat events are considered part of the 'uptime' dataset, even though their data may differ. The key thing defining this dataset is the presence of the `monitor.status` field (cherry picked from commit 5e54acb)
andrewvc
added a commit
that referenced
this pull request
Dec 20, 2018
* Add event.dataset field (#9408) This brings us closer to ECS compliance by adding the event.dataset field. All heartbeat events are considered part of the 'uptime' dataset, even though their data may differ. The key thing defining this dataset is the presence of the `monitor.status` field (cherry picked from commit 5e54acb) * Fix test failures by cleaning more keys * Add event.dataset to common fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings us closer to ECS compliance by adding the event.dataset field.
All heartbeat events are considered part of the 'uptime' dataset, even though their data may differ.
The key thing defining this dataset is the presence of the
monitor.statusfield.