Cherry-pick #9408 to 6.x: Add event.dataset field#9561
Merged
andrewvc merged 3 commits intoelastic:6.xfrom Dec 20, 2018
Merged
Conversation
This brings us closer to ECS compliance by adding the event.dataset field. All heartbeat events are considered part of the 'uptime' dataset, even though their data may differ. The key thing defining this dataset is the presence of the `monitor.status` field (cherry picked from commit 5e54acb)
Contributor
|
The build fails because |
16113de to
51479d2
Compare
Contributor
|
jenkins, test this |
Contributor
Author
|
@ruflin are you good with me merging this? Jenkins is passing, travis is not but it looks unrelated |
ruflin
approved these changes
Dec 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #9408 to 6.x branch. Original message:
This brings us closer to ECS compliance by adding the event.dataset field.
All heartbeat events are considered part of the 'uptime' dataset, even though their data may differ.
The key thing defining this dataset is the presence of the
monitor.statusfield.