Do not rely on an specific memcached version for autodiscover test#8656
Merged
exekias merged 1 commit intoelastic:masterfrom Oct 19, 2018
Merged
Do not rely on an specific memcached version for autodiscover test#8656exekias merged 1 commit intoelastic:masterfrom
exekias merged 1 commit intoelastic:masterfrom
Conversation
Old versions are sometimes removed, as this test is not about the module itself we can use the latest tag here
ruflin
approved these changes
Oct 19, 2018
| 'templates': ''' | ||
| - condition: | ||
| equals.docker.container.image: memcached:1.5.3 | ||
| equals.docker.container.image: memcached:latest |
Contributor
There was a problem hiding this comment.
I'm torn here. In general I prefer that we use fixed versions for consistency but it seem for the autodiscovery test the content does not really matter.
exekias
added a commit
to exekias/beats
that referenced
this pull request
Oct 19, 2018
…lastic#8656) Old versions are sometimes removed, as this test is not about the module itself we can use the latest tag here (cherry picked from commit b2ba2ea)
exekias
added a commit
to exekias/beats
that referenced
this pull request
Oct 19, 2018
…lastic#8656) Old versions are sometimes removed, as this test is not about the module itself we can use the latest tag here (cherry picked from commit b2ba2ea)
exekias
added a commit
that referenced
this pull request
Oct 22, 2018
exekias
added a commit
that referenced
this pull request
Oct 22, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#8656) (elastic#8665) Old versions are sometimes removed, as this test is not about the module itself we can use the latest tag here (cherry picked from commit 1555a9c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue seen in travis:
Old versions are sometimes removed, as this test is not about the module
itself we can use the latest tag here.