Skip to content

Commit b2ba2ea

Browse files
authored
Do not rely on an specific memcached version for autodiscover test (#8656)
Old versions are sometimes removed, as this test is not about the module itself we can use the latest tag here
1 parent 450071d commit b2ba2ea

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

metricbeat/tests/system/test_autodiscover.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def test_docker(self):
2525
'docker': {
2626
'templates': '''
2727
- condition:
28-
equals.docker.container.image: memcached:1.5.3
28+
equals.docker.container.image: memcached:latest
2929
config:
3030
- module: memcached
3131
metricsets: ["stats"]
@@ -37,8 +37,8 @@ def test_docker(self):
3737
)
3838

3939
proc = self.start_beat()
40-
docker_client.images.pull('memcached:1.5.3')
41-
container = docker_client.containers.run('memcached:1.5.3', detach=True)
40+
docker_client.images.pull('memcached:latest')
41+
container = docker_client.containers.run('memcached:latest', detach=True)
4242

4343
self.wait_until(lambda: self.log_contains('Starting runner: memcached'))
4444

@@ -51,7 +51,7 @@ def test_docker(self):
5151
proc.check_kill_and_wait()
5252

5353
# Check metadata is added
54-
assert output[0]['docker']['container']['image'] == 'memcached:1.5.3'
54+
assert output[0]['docker']['container']['image'] == 'memcached:latest'
5555
assert output[0]['docker']['container']['labels'] == {}
5656
assert 'name' in output[0]['docker']['container']
5757

@@ -74,13 +74,13 @@ def test_docker_labels(self):
7474
)
7575

7676
proc = self.start_beat()
77-
docker_client.images.pull('memcached:1.5.3')
77+
docker_client.images.pull('memcached:latest')
7878
labels = {
7979
'co.elastic.metrics/module': 'memcached',
8080
'co.elastic.metrics/period': '1s',
8181
'co.elastic.metrics/hosts': "'${data.host}:11211'",
8282
}
83-
container = docker_client.containers.run('memcached:1.5.3', labels=labels, detach=True)
83+
container = docker_client.containers.run('memcached:latest', labels=labels, detach=True)
8484

8585
self.wait_until(lambda: self.log_contains('Starting runner: memcached'))
8686

@@ -93,5 +93,5 @@ def test_docker_labels(self):
9393
proc.check_kill_and_wait()
9494

9595
# Check metadata is added
96-
assert output[0]['docker']['container']['image'] == 'memcached:1.5.3'
96+
assert output[0]['docker']['container']['image'] == 'memcached:latest'
9797
assert 'name' in output[0]['docker']['container']

0 commit comments

Comments
 (0)