Switch to different UUID lib due to non-random generated UUIDs#8458
Switch to different UUID lib due to non-random generated UUIDs#8458kvch merged 12 commits intoelastic:masterfrom
Conversation
|
|
|
Seems like |
ph
left a comment
There was a problem hiding this comment.
LGTM just a minor things about the changelog.
Thanks for propagating this error!
CHANGELOG.asciidoc
Outdated
There was a problem hiding this comment.
Can we insert why we switch probably adding a word about collision in the old library.
5bf4cbe to
5ec6d4e
Compare
|
Updated changelog entry and rebased on top of #8469 |
|
Make check fails on CI |
andrewkroh
left a comment
There was a problem hiding this comment.
Thanks for looking it to this issue. Only minor comments from me.
There was a problem hiding this comment.
What's the impact to monitoring if the ephemeral ID is Nil?
There was a problem hiding this comment.
The beat won't show up in some visualizations.
There was a problem hiding this comment.
Use uuid.Nil here? It's the same but slightly more clear.
|
I just merged #8559, which adds a new use of this lib in |
* no longer maintained * contains critical bug which leads to generating similar and same UUIDs
|
This should be ready for the next round of review. |
…ic#8458) The previously used `github.com/satori/go-uuid` lib has a critical bug and it is no longer maintained. The community moved to an active fork of this existing lib named `github.com/gofrs/uuid`. I haven't seen other UUID libs worth mentioning apart from this. Changes compared to the previous dependency: * `uuid.NewV4` returns an error if the function call failed * `uuid.Equal` is deprecated and removed. The Way is to use `==` instead. Closes elastic#8077 (cherry picked from commit 554ddcd)
#8640) The previously used `github.com/satori/go-uuid` lib has a critical bug and it is no longer maintained. The community moved to an active fork of this existing lib named `github.com/gofrs/uuid`. I haven't seen other UUID libs worth mentioning apart from this. Changes compared to the previous dependency: * `uuid.NewV4` returns an error if the function call failed * `uuid.Equal` is deprecated and removed. The Way is to use `==` instead. Closes #8077 (cherry picked from commit 554ddcd)
The previously used
github.com/satori/go-uuidlib has a critical bug and it is no longer maintained. The community moved to an active fork of this existing lib namedgithub.com/gofrs/uuid. I haven't seen other UUID libs worth mentioning apart from this.Changes compared to the previous dependency:
uuid.NewV4returns an error if the function call faileduuid.Equalis deprecated and removed. The Way is to use==instead.TODO
github.com/elastic/go-ucfgCloses #8077