Cherry-pick #8458 to 6.x: Switch to different UUID lib due to non-random generated UUIDs#8640
Merged
kvch merged 1 commit intoelastic:6.xfrom Oct 18, 2018
Merged
Conversation
…ic#8458) The previously used `github.com/satori/go-uuid` lib has a critical bug and it is no longer maintained. The community moved to an active fork of this existing lib named `github.com/gofrs/uuid`. I haven't seen other UUID libs worth mentioning apart from this. Changes compared to the previous dependency: * `uuid.NewV4` returns an error if the function call failed * `uuid.Equal` is deprecated and removed. The Way is to use `==` instead. Closes elastic#8077 (cherry picked from commit 554ddcd)
6b92126 to
3b33008
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8458 to 6.x branch. Original message:
The previously used
github.com/satori/go-uuidlib has a critical bug and it is no longer maintained. The community moved to an active fork of this existing lib namedgithub.com/gofrs/uuid. I haven't seen other UUID libs worth mentioning apart from this.Changes compared to the previous dependency:
uuid.NewV4returns an error if the function call faileduuid.Equalis deprecated and removed. The Way is to use==instead.TODO
github.com/elastic/go-ucfgCloses #8077