Skip to content

Update elastic-agent-system-metrics to fix #48690#48830

Merged
belimawr merged 11 commits intoelastic:mainfrom
belimawr:update-elastic-agent-system-metrics
Feb 21, 2026
Merged

Update elastic-agent-system-metrics to fix #48690#48830
belimawr merged 11 commits intoelastic:mainfrom
belimawr:update-elastic-agent-system-metrics

Conversation

@belimawr
Copy link
Copy Markdown
Contributor

Proposed commit message

See title

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

## Disruptive User Impact
## Author's Checklist

How to test this PR locally

The reproduction steps are a modified version of #48690. Here the discard output is used.

cat <<'EOF' > repro.yml
logging.level: error
metricbeat.modules:
- module: system
  metricsets: ["cpu"]
  hostfs: "/hostfs"
  period: 10s
output.discard:
    enabled: true
EOF

docker run --rm \
  --name=metricbeat \
  --volume="$(pwd)/repro.yml:/usr/share/metricbeat/metricbeat.yml:ro" \
  --volume="/var/run/docker.sock:/var/run/docker.sock:ro" \
  --volume="/sys/fs/cgroup:/hostfs/sys/fs/cgroup:ro" \
  --volume="/proc:/hostfs/proc:ro" \
  --volume="/:/hostfs:ro" \
  docker.elastic.co/beats/metricbeat:9.3.0 metricbeat -e

Because the log level is set to error in the configuration file and this PR fixes the error, there will be no logs.

Related issues

## Use cases
## Screenshots
## Logs

@belimawr belimawr requested a review from a team as a code owner February 12, 2026 16:52
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 12, 2026
@belimawr belimawr self-assigned this Feb 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@belimawr belimawr added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team skip-changelog labels Feb 12, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 12, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 12, 2026

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @belimawr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@belimawr belimawr added the backport-active-all Automated backport with mergify to all the active branches label Feb 12, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 13, 2026

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update-elastic-agent-system-metrics upstream/update-elastic-agent-system-metrics
git merge upstream/main
git push upstream update-elastic-agent-system-metrics

Copy link
Copy Markdown
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending fixing the conflicts in the go.sum file. Tested locally with the reproducer from the issue, no errors reported.

@belimawr
Copy link
Copy Markdown
Contributor Author

The tests failed because of #48902

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 19, 2026

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update-elastic-agent-system-metrics upstream/update-elastic-agent-system-metrics
git merge upstream/main
git push upstream update-elastic-agent-system-metrics

@belimawr belimawr enabled auto-merge (squash) February 20, 2026 16:08
@belimawr belimawr merged commit 5b79ccc into elastic:main Feb 21, 2026
209 of 211 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

@Mergifyio backport 8.19 9.2 9.3

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 21, 2026

backport 8.19 9.2 9.3

✅ Backports have been created

Details

Cherry-pick of 5b79ccc has failed:

On branch mergify/bp/8.19/pr-48830
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 5b79ccc9d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   NOTICE.txt
	both modified:   go.mod
	both modified:   go.sum

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of 5b79ccc has failed:

On branch mergify/bp/9.2/pr-48830
Your branch is up to date with 'origin/9.2'.

You are currently cherry-picking commit 5b79ccc9d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   NOTICE.txt
	both modified:   go.mod
	both modified:   go.sum

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of 5b79ccc has failed:

On branch mergify/bp/9.3/pr-48830
Your branch is up to date with 'origin/9.3'.

You are currently cherry-picking commit 5b79ccc9d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   NOTICE.txt
	both modified:   go.mod
	both modified:   go.sum

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify bot pushed a commit that referenced this pull request Feb 21, 2026
(cherry picked from commit 5b79ccc)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
mergify bot pushed a commit that referenced this pull request Feb 21, 2026
(cherry picked from commit 5b79ccc)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
mergify bot pushed a commit that referenced this pull request Feb 21, 2026
(cherry picked from commit 5b79ccc)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
belimawr added a commit that referenced this pull request Feb 24, 2026
 (#49026)

(cherry picked from commit 5b79ccc)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum

* Fix merge conflicts

---------

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
belimawr added a commit that referenced this pull request Feb 24, 2026
 (#49025)

(cherry picked from commit 5b79ccc)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum

* Fix merge conflicts

---------

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
belimawr added a commit that referenced this pull request Feb 25, 2026
…8690 (#49024)

(cherry picked from commit 5b79ccc)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum

* Fix merge conflicts

---------

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
@belimawr belimawr deleted the update-elastic-agent-system-metrics branch March 2, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metricbeat container throws errors when fetching metrics with hostfs set

5 participants