Skip to content

[Chore] Replace global logger with local logger #10#45086

Merged
khushijain21 merged 13 commits intoelastic:mainfrom
khushijain21:locallogger10
Jul 7, 2025
Merged

[Chore] Replace global logger with local logger #10#45086
khushijain21 merged 13 commits intoelastic:mainfrom
khushijain21:locallogger10

Conversation

@khushijain21
Copy link
Copy Markdown
Contributor

@khushijain21 khushijain21 commented Jun 27, 2025 •
edited
Loading

Proposed commit message

With this PR x-pack/metricbeat is now global logger free

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@khushijain21 khushijain21 requested review from a team as code owners June 27, 2025 11:29
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 27, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 27, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@khushijain21 khushijain21 marked this pull request as draft June 27, 2025 11:30
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

khushijain21
khushijain21 commented Jun 27, 2025
View reviewed changes
khushijain21
khushijain21 commented Jun 27, 2025
View reviewed changes
leehinman
leehinman approved these changes Jun 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the comments on why certain log lines were removed or loggers renamed, that helped a lot.

efd6
efd6 approved these changes Jun 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSI files LGTM

@khushijain21 khushijain21 marked this pull request as ready for review June 30, 2025 05:18
@khushijain21
Copy link
Copy Markdown
Contributor Author

khushijain21 commented Jun 30, 2025 •
edited
Loading

cc: @lalit-satapathy, @bturquet, @qcorporation, @nfritts

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 30, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 30, 2025

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@khushijain21 khushijain21 added needs_team Indicates that the issue/PR needs a Team:* label Team:Security-Windows Platform Windows Platform Team in Security Solution labels Jun 30, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 30, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 30, 2025

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@khushijain21 khushijain21 added needs_team Indicates that the issue/PR needs a Team:* label Team:Security-Linux Platform Linux Platform Team in Security Solution labels Jun 30, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 30, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 30, 2025

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@botelastic
Copy link
Copy Markdown

botelastic bot commented Jun 30, 2025

This pull request doesn't have a Team:<team> label.

@pierrehilbert
Copy link
Copy Markdown
Contributor

pierrehilbert commented Jul 1, 2025

@lalit-satapathy / @jlind23 (Baptiste being out) / @nfritts / @qcorporation : approval is needed from your team here.

zmoog
zmoog approved these changes Jul 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elastic/obs-ds-hosted-services files LGTM.

@khushijain21 khushijain21 added backport-9.1 Automated backport to the 9.1 branch backport-8.19 Automated backport to the 8.19 branch and removed backport-9.1 Automated backport to the 9.1 branch labels Jul 7, 2025
@khushijain21 khushijain21 enabled auto-merge (squash) July 7, 2025 15:14
@khushijain21 khushijain21 merged commit 4350d4e into elastic:main Jul 7, 2025
245 of 248 checks passed
mergify bot pushed a commit that referenced this pull request Jul 7, 2025
@khushijain21 @mergify
[Chore] Replace global logger with local logger #10 (#45086)
0d42f19 
* [Chore] Replace global logger with local logger #10

(cherry picked from commit 4350d4e)

# Conflicts:
#	metricbeat/module/jolokia/jmx/data.go
@mergify mergify bot mentioned this pull request Jul 7, 2025
Merged
6 tasks
khushijain21 pushed a commit that referenced this pull request Jul 10, 2025
@mergify
[8.19](backport #45086) [Chore] Replace global logger with local logger
04d768d 
#10 (#45220)

* [Chore] Replace global logger with local logger #10 (#45086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes

@mauri870 mauri870 mauri870 approved these changes

@shmsr shmsr shmsr approved these changes

@nfritts nfritts nfritts approved these changes

@leehinman leehinman leehinman approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@efd6 efd6 efd6 approved these changes

@taylor-swanson taylor-swanson taylor-swanson approved these changes

@stefans-elastic stefans-elastic stefans-elastic approved these changes

Assignees

@khushijain21 khushijain21

Labels

backport-8.19 Automated backport to the 8.19 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution Team:Security-Linux Platform Linux Platform Team in Security Solution Team:Security-Windows Platform Windows Platform Team in Security Solution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.