Skip to content

[8.19](backport #45086) [Chore] Replace global logger with local logger #10#45220

Merged
khushijain21 merged 4 commits into8.19from
mergify/bp/8.19/pr-45086
Jul 10, 2025
Merged

[8.19](backport #45086) [Chore] Replace global logger with local logger #10#45220
khushijain21 merged 4 commits into8.19from
mergify/bp/8.19/pr-45086

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jul 7, 2025

Proposed commit message

With this PR x-pack/metricbeat is now global logger free

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

This is an automatic backport of pull request #45086 done by [Mergify](https://mergify.com).

@khushijain21 @mergify
[Chore] Replace global logger with local logger #10 (#45086)
0d42f19 
* [Chore] Replace global logger with local logger #10

(cherry picked from commit 4350d4e)

# Conflicts:
#	metricbeat/module/jolokia/jmx/data.go
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jul 7, 2025
@mergify mergify bot requested a review from a team as a code owner July 7, 2025 15:15
@mergify mergify bot added the backport label Jul 7, 2025
@mergify mergify bot requested review from a team as code owners July 7, 2025 15:15
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Jul 7, 2025
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Jul 7, 2025

Cherry-pick of 4350d4e has failed:

On branch mergify/bp/8.19/pr-45086
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 4350d4ee2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   auditbeat/module/file_integrity/eventreader_kprobes.go
	modified:   filebeat/beater/diagnostics.go
	modified:   filebeat/beater/filebeat.go
	modified:   filebeat/input/filestream/input.go
	modified:   filebeat/input/journald/input.go
	modified:   filebeat/input/kafka/input.go
	modified:   filebeat/input/log/harvester.go
	modified:   filebeat/input/registry.go
	modified:   filebeat/registrar/migrate.go
	modified:   filebeat/scripts/tester/main.go
	modified:   libbeat/outputs/elasticsearch/client.go
	modified:   libbeat/outputs/elasticsearch/client_test.go
	modified:   libbeat/processors/add_cloud_metadata/generic_fetcher.go
	modified:   libbeat/processors/add_cloud_metadata/http_fetcher.go
	modified:   libbeat/processors/add_cloud_metadata/provider_azure_vm.go
	modified:   libbeat/processors/add_cloud_metadata/providers.go
	modified:   libbeat/processors/add_docker_metadata/add_docker_metadata.go
	modified:   libbeat/processors/add_locale/add_locale_test.go
	modified:   libbeat/processors/add_process_metadata/add_process_metadata.go
	modified:   libbeat/processors/add_process_metadata/add_process_metadata_test.go
	modified:   libbeat/processors/add_process_metadata/gosigar_cid_provider.go
	modified:   libbeat/processors/decode_xml/decode_xml.go
	modified:   libbeat/processors/decode_xml/decode_xml_test.go
	modified:   libbeat/processors/decode_xml_wineventlog/decoder.go
	modified:   libbeat/processors/decode_xml_wineventlog/decoder_windows.go
	modified:   libbeat/processors/decode_xml_wineventlog/processor.go
	modified:   libbeat/processors/fingerprint/fingerprint_test.go
	modified:   libbeat/processors/ratelimit/algorithm.go
	modified:   libbeat/processors/ratelimit/rate_limit.go
	modified:   libbeat/processors/ratelimit/rate_limit_test.go
	modified:   libbeat/processors/ratelimit/token_bucket.go
	modified:   libbeat/processors/registered_domain/registered_domain.go
	modified:   libbeat/processors/registered_domain/registered_domain_test.go
	modified:   libbeat/processors/timestamp/timestamp.go
	modified:   libbeat/processors/timestamp/timestamp_test.go
	modified:   libbeat/processors/translate_ldap_attribute/translate_ldap_attribute.go
	modified:   libbeat/processors/translate_sid/translatesid.go
	modified:   libbeat/processors/translate_sid/translatesid_test.go
	modified:   libbeat/reader/filter/filter.go
	modified:   libbeat/reader/filter/filter_test.go
	modified:   libbeat/reader/multiline/multiline.go
	modified:   libbeat/reader/multiline/multiline_test.go
	modified:   libbeat/reader/multiline/pattern.go
	modified:   libbeat/reader/multiline/while.go
	modified:   libbeat/reader/parser/parser.go
	modified:   libbeat/reader/parser/parser_example_test.go
	modified:   libbeat/reader/parser/parser_test.go
	modified:   libbeat/reader/readjson/docker_json.go
	modified:   libbeat/reader/readjson/docker_json_test.go
	modified:   libbeat/reader/readjson/json.go
	modified:   libbeat/reader/readjson/json_test.go
	modified:   libbeat/reader/syslog/syslog.go
	modified:   libbeat/reader/syslog/syslog_test.go
	modified:   metricbeat/mb/module/factory.go
	modified:   metricbeat/mb/module/wrapper.go
	modified:   metricbeat/mb/module/wrapper_internal_test.go
	modified:   metricbeat/mb/module/wrapper_test.go
	modified:   metricbeat/module/docker/cpu/cpu.go
	modified:   metricbeat/module/docker/cpu/cpu_test.go
	modified:   metricbeat/module/docker/cpu/helper.go
	modified:   metricbeat/module/jolokia/jmx/config.go
	modified:   metricbeat/module/jolokia/jmx/config_test.go
	modified:   metricbeat/module/jolokia/jmx/data_test.go
	modified:   metricbeat/module/jolokia/jmx/jmx.go
	modified:   metricbeat/module/system/socket/socket.go
	modified:   x-pack/filebeat/input/awss3/s3_input.go
	modified:   x-pack/filebeat/input/awss3/s3_objects.go
	modified:   x-pack/filebeat/input/awss3/script.go
	modified:   x-pack/filebeat/input/awss3/script_session.go
	modified:   x-pack/filebeat/processors/add_nomad_metadata/matchers.go
	modified:   x-pack/filebeat/processors/add_nomad_metadata/matchers_test.go
	modified:   x-pack/filebeat/processors/aws_vpcflow/parse_aws_vpc_flow_log.go
	modified:   x-pack/filebeat/processors/aws_vpcflow/parse_aws_vpc_flow_log_test.go
	modified:   x-pack/filebeat/processors/decode_cef/decode_cef.go
	modified:   x-pack/filebeat/processors/decode_cef/decode_cef_test.go
	modified:   x-pack/libbeat/processors/add_nomad_metadata/matchers.go
	modified:   x-pack/libbeat/processors/add_nomad_metadata/nomad.go
	modified:   x-pack/metricbeat/module/azure/app_insights/app_insights.go
	modified:   x-pack/metricbeat/module/azure/app_insights/client.go
	modified:   x-pack/metricbeat/module/azure/app_insights/client_test.go
	modified:   x-pack/metricbeat/module/azure/app_insights/mock_service.go
	modified:   x-pack/metricbeat/module/azure/app_insights/service.go
	modified:   x-pack/metricbeat/module/azure/azure.go
	modified:   x-pack/metricbeat/module/azure/billing/billing.go
	modified:   x-pack/metricbeat/module/azure/billing/client.go
	modified:   x-pack/metricbeat/module/azure/billing/client_test.go
	modified:   x-pack/metricbeat/module/azure/billing/mock_service.go
	modified:   x-pack/metricbeat/module/azure/billing/service.go
	modified:   x-pack/metricbeat/module/azure/client.go
	modified:   x-pack/metricbeat/module/azure/client_batch.go
	modified:   x-pack/metricbeat/module/azure/client_batch_test.go
	modified:   x-pack/metricbeat/module/azure/client_test.go
	modified:   x-pack/metricbeat/module/azure/monitor/client_helper_concurrent_test.go
	modified:   x-pack/metricbeat/module/azure/monitor/client_helper_test.go
	modified:   x-pack/metricbeat/module/azure/monitor_service.go
	modified:   x-pack/metricbeat/module/azure/storage/client_helper_concurrent_test.go
	modified:   x-pack/metricbeat/module/azure/storage/client_helper_test.go
	modified:   x-pack/metricbeat/module/gcp/metrics/cloudsql/metadata.go
	modified:   x-pack/metricbeat/module/gcp/metrics/compute/metadata.go
	modified:   x-pack/metricbeat/module/gcp/metrics/dataproc/metadata.go
	modified:   x-pack/metricbeat/module/gcp/metrics/metadata_services.go
	modified:   x-pack/metricbeat/module/gcp/metrics/metricset.go
	modified:   x-pack/metricbeat/module/gcp/metrics/redis/metadata.go
	modified:   x-pack/metricbeat/module/iis/application_pool/application_pool.go
	modified:   x-pack/metricbeat/module/iis/application_pool/reader.go
	modified:   x-pack/metricbeat/module/iis/application_pool/reader_test.go
	modified:   x-pack/metricbeat/module/meraki/device_health/device_health.go
	modified:   x-pack/metricbeat/module/meraki/device_health/vpn_status.go
	modified:   x-pack/metricbeat/module/meraki/http.go
	modified:   x-pack/metricbeat/module/meraki/http_test.go
	modified:   x-pack/metricbeat/module/meraki/network_health/network_health.go
	modified:   x-pack/metricbeat/module/meraki/network_health/vpn_stats.go
	modified:   x-pack/metricbeat/module/mssql/transaction_log/transaction_log.go
	modified:   x-pack/metricbeat/module/prometheus/collector/data.go
	modified:   x-pack/metricbeat/module/prometheus/remote_write/data.go
	modified:   x-pack/metricbeat/module/statsd/server/registry.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   metricbeat/module/jolokia/jmx/data.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested review from a team as code owners July 7, 2025 15:15
@mergify mergify bot removed the request for review from a team July 7, 2025 15:15
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 7, 2025
@mergify mergify bot requested review from AndersonQ and khushijain21 July 7, 2025 15:15
@github-actions github-actions bot added Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team Team:Security-Linux Platform Linux Platform Team in Security Solution Team:Security-Windows Platform Windows Platform Team in Security Solution Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Jul 7, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 7, 2025

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 7, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 7, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 7, 2025

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 7, 2025

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 7, 2025

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@khushijain21 khushijain21 merged commit 04d768d into 8.19 Jul 10, 2025
241 of 244 checks passed
@khushijain21 khushijain21 deleted the mergify/bp/8.19/pr-45086 branch July 10, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjwolf mjwolf mjwolf approved these changes

@khushijain21 khushijain21 khushijain21 approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@khushijain21 khushijain21

Labels

backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution Team:Security-Linux Platform Linux Platform Team in Security Solution Team:Security-Windows Platform Windows Platform Team in Security Solution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elasticmachine @mjwolf @khushijain21