Skip to content

fix(tests): relax TestGroup_Go timeouts#42862

Merged
mauri870 merged 3 commits intoelastic:mainfrom
mauri870:fix-test-group
Feb 26, 2025
Merged

fix(tests): relax TestGroup_Go timeouts#42862
mauri870 merged 3 commits intoelastic:mainfrom
mauri870:fix-test-group

Conversation

@mauri870
Copy link
Copy Markdown
Member

@mauri870 mauri870 commented Feb 24, 2025

Proposed commit message

The TestGroup_Go subtests are known to be flaky, likely due to small assertion timeouts. On Windows, these assertions take longer to complete than on Unix systems. This change relaxes the timeouts to improve stability.

I ran the tests locally with x/tools/cmd/stress and it appears to have stabilized:

13m30s: 105896 runs so far, 0 failures, 32 active

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

On a windows box:

$ cd filebeat/input/filestream/internal/task 
$ go test -c
$ go run golang.org/x/tools/cmd/stress@latest -p 32 ./task.test -test.run TestGroup_Go -test.v

Related issues

@mauri870 mauri870 added flaky-test Unstable or unreliable test cases. Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Feb 24, 2025
@mauri870 mauri870 self-assigned this Feb 24, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 24, 2025
@mauri870 mauri870 marked this pull request as ready for review February 24, 2025 12:30
@mauri870 mauri870 requested a review from a team as a code owner February 24, 2025 12:30
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 24, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 24, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @mauri870? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@mauri870 mauri870 enabled auto-merge (squash) February 24, 2025 12:31
@mauri870 mauri870 added the backport-active-all Automated backport with mergify to all the active branches label Feb 24, 2025
@mauri870
Copy link
Copy Markdown
Member Author

mauri870 commented Feb 25, 2025

/test

@mauri870 mauri870 merged commit a4bc9f0 into elastic:main Feb 26, 2025
mergify bot pushed a commit that referenced this pull request Feb 26, 2025
@mauri870 @mergify
fix(tests): relax TestGroup_Go timeouts (#42862)
abd72f8 
(cherry picked from commit a4bc9f0)
@mergify mergify bot mentioned this pull request Feb 26, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Feb 26, 2025
@mauri870 @mergify
fix(tests): relax TestGroup_Go timeouts (#42862)
c7f16c1 
(cherry picked from commit a4bc9f0)
@mergify mergify bot mentioned this pull request Feb 26, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Feb 26, 2025
@mauri870 @mergify
fix(tests): relax TestGroup_Go timeouts (#42862)
9e110a0 
(cherry picked from commit a4bc9f0)
@mergify mergify bot mentioned this pull request Feb 26, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Feb 26, 2025
@mauri870 @mergify
fix(tests): relax TestGroup_Go timeouts (#42862)
179026d 
(cherry picked from commit a4bc9f0)
@mergify mergify bot mentioned this pull request Feb 26, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Feb 26, 2025
@mauri870 @mergify
fix(tests): relax TestGroup_Go timeouts (#42862)
8f02475 
(cherry picked from commit a4bc9f0)
mergify bot pushed a commit that referenced this pull request Feb 26, 2025
@mauri870 @mergify
fix(tests): relax TestGroup_Go timeouts (#42862)
e1e7e6f 
(cherry picked from commit a4bc9f0)

# Conflicts:
#	filebeat/input/filestream/internal/task/group_test.go
@mergify mergify bot mentioned this pull request Feb 26, 2025
Merged
6 tasks
@mergify mergify bot mentioned this pull request Feb 26, 2025
Closed
6 tasks
mauri870 added a commit that referenced this pull request Feb 26, 2025
@mergify @mauri870
fix(tests): relax TestGroup_Go timeouts (#42862) (#42909)
5956d32 
(cherry picked from commit a4bc9f0)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Feb 26, 2025
@mergify @mauri870
fix(tests): relax TestGroup_Go timeouts (#42862) (#42907)
95c76ed 
(cherry picked from commit a4bc9f0)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Feb 26, 2025
@mergify @mauri870
fix(tests): relax TestGroup_Go timeouts (#42862) (#42908)
e6d802b 
(cherry picked from commit a4bc9f0)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Feb 26, 2025
@mergify @mauri870
fix(tests): relax TestGroup_Go timeouts (#42862) (#42906)
1733b68 
(cherry picked from commit a4bc9f0)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Feb 26, 2025
@mergify @mauri870
fix(tests): relax TestGroup_Go timeouts (#42862) (#42910)
200ba1a 
(cherry picked from commit a4bc9f0)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@khushijain21 khushijain21 Awaiting requested review from khushijain21 khushijain21 is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@mauri870 mauri870

Labels

backport-active-all Automated backport with mergify to all the active branches flaky-test Unstable or unreliable test cases. Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestGroup_Go - not all goroutines finished/"task.Group: semaphore acquire failed, was the task group closed? err: context canceled

4 participants

@mauri870 @elasticmachine @VihasMakwana @jlind23