Skip to content

[8.16](backport #42862) fix(tests): relax TestGroup_Go timeouts#42909

Merged
mauri870 merged 1 commit into8.16from
mergify/bp/8.16/pr-42862
Feb 26, 2025
Merged

[8.16](backport #42862) fix(tests): relax TestGroup_Go timeouts#42909
mauri870 merged 1 commit into8.16from
mergify/bp/8.16/pr-42862

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Feb 26, 2025

Proposed commit message

The TestGroup_Go subtests are known to be flaky, likely due to small assertion timeouts. On Windows, these assertions take longer to complete than on Unix systems. This change relaxes the timeouts to improve stability.

I ran the tests locally with x/tools/cmd/stress and it appears to have stabilized:

13m30s: 105896 runs so far, 0 failures, 32 active

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

On a windows box:

$ cd filebeat/input/filestream/internal/task 
$ go test -c
$ go run golang.org/x/tools/cmd/stress@latest -p 32 ./task.test -test.run TestGroup_Go -test.v

Related issues

@mergify mergify bot requested a review from a team as a code owner February 26, 2025 11:04
@mergify mergify bot added the backport label Feb 26, 2025
@mergify mergify bot requested review from AndersonQ and belimawr and removed request for a team February 26, 2025 11:04
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 26, 2025
@botelastic
Copy link
Copy Markdown

botelastic bot commented Feb 26, 2025

This pull request doesn't have a Team:<team> label.

@mauri870 mauri870 requested review from mauri870 and removed request for AndersonQ and belimawr February 26, 2025 11:13
@mauri870 mauri870 enabled auto-merge (squash) February 26, 2025 11:13
@mauri870 mauri870 merged commit 5956d32 into 8.16 Feb 26, 2025
@mauri870 mauri870 deleted the mergify/bp/8.16/pr-42862 branch February 26, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant