Conversation
This splits the common module parts and the gosysinfo backend. Needed for an upcoming PR which adds a quark backend, so I'm splitting this earlier to make review easier. Only functional case for this PR is add missing `bucket.Close()` calls in New().
Contributor
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
These are from old code that is only now being touched and linted.
Contributor
fearful-symmetry
left a comment
There was a problem hiding this comment.
It looks like this is basically moving code around? If so, we can probably take it out of draft?
fearful-symmetry
approved these changes
Dec 3, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
This splits the common module parts and the gosysinfo backend. Needed for an upcoming PR which adds a quark backend, so I'm splitting this earlier to make review easier. Only functional case for this PR is add missing `bucket.Close()` calls in New(). (cherry picked from commit 5a85598) # Conflicts: # x-pack/auditbeat/module/system/process/process.go
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
This splits the common module parts and the gosysinfo backend. Needed for an upcoming PR which adds a quark backend, so I'm splitting this earlier to make review easier. Only functional case for this PR is add missing `bucket.Close()` calls in New(). (cherry picked from commit 5a85598)
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
This splits the common module parts and the gosysinfo backend. Needed for an upcoming PR which adds a quark backend, so I'm splitting this earlier to make review easier. Only functional case for this PR is add missing `bucket.Close()` calls in New(). (cherry picked from commit 5a85598)
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
This splits the common module parts and the gosysinfo backend. Needed for an upcoming PR which adds a quark backend, so I'm splitting this earlier to make review easier. Only functional case for this PR is add missing `bucket.Close()` calls in New(). (cherry picked from commit 5a85598)
2 tasks
haesbaert
added a commit
that referenced
this pull request
Dec 3, 2024
This splits the common module parts and the gosysinfo backend. Needed for an upcoming PR which adds a quark backend, so I'm splitting this earlier to make review easier. Only functional case for this PR is add missing `bucket.Close()` calls in New(). (cherry picked from commit 5a85598) Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
haesbaert
added a commit
that referenced
this pull request
Dec 4, 2024
This splits the common module parts and the gosysinfo backend. Needed for an upcoming PR which adds a quark backend, so I'm splitting this earlier to make review easier. Only functional case for this PR is add missing `bucket.Close()` calls in New(). (cherry picked from commit 5a85598) Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
haesbaert
added a commit
that referenced
this pull request
Dec 4, 2024
This splits the common module parts and the gosysinfo backend. Needed for an upcoming PR which adds a quark backend, so I'm splitting this earlier to make review easier. Only functional case for this PR is add missing `bucket.Close()` calls in New(). (cherry picked from commit 5a85598) Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
haesbaert
added a commit
that referenced
this pull request
Dec 5, 2024
* auditbeat: split system process module (#41868) This splits the common module parts and the gosysinfo backend. Needed for an upcoming PR which adds a quark backend, so I'm splitting this earlier to make review easier. Only functional case for this PR is add missing `bucket.Close()` calls in New(). (cherry picked from commit 5a85598) Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits the common module parts and the gosysinfo backend. Needed for an upcoming PR which adds a quark backend, so I'm splitting this earlier to make review easier.
Only functional change for this PR is adding two missing
bucket.Close()calls in New().Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.