Skip to content

[8.15](backport #41868) auditbeat: split system process module#41877

Merged
haesbaert merged 3 commits into8.15from
mergify/bp/8.15/pr-41868
Dec 5, 2024
Merged

[8.15](backport #41868) auditbeat: split system process module#41877
haesbaert merged 3 commits into8.15from
mergify/bp/8.15/pr-41868

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Dec 3, 2024

This splits the common module parts and the gosysinfo backend. Needed for an upcoming PR which adds a quark backend, so I'm splitting this earlier to make review easier.

Only functional change for this PR is adding two missing bucket.Close() calls in New().

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.
    This is an automatic backport of pull request auditbeat: split system process module #41868 done by Mergify.

This splits the common module parts and the gosysinfo backend.
Needed for an upcoming PR which adds a quark backend, so I'm splitting this
earlier to make review easier.

Only functional case for this PR is add missing `bucket.Close()` calls in New().

(cherry picked from commit 5a85598)

# Conflicts:
#	x-pack/auditbeat/module/system/process/process.go
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Dec 3, 2024
@mergify mergify bot requested a review from a team as a code owner December 3, 2024 20:23
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Dec 3, 2024

Cherry-pick of 5a85598 has failed:

On branch mergify/bp/8.15/pr-41868
Your branch is up to date with 'origin/8.15'.

You are currently cherry-picking commit 5a85598f4e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc
	new file:   x-pack/auditbeat/module/system/process/gosysinfo_provider.go
	modified:   x-pack/auditbeat/module/system/process/process_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x-pack/auditbeat/module/system/process/process.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 3, 2024
@haesbaert haesbaert added the Team:Security-Linux Platform Linux Platform Team in Security Solution label Dec 3, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 3, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@haesbaert haesbaert enabled auto-merge (squash) December 5, 2024 17:25
@haesbaert haesbaert merged commit fcc1995 into 8.15 Dec 5, 2024
@haesbaert haesbaert deleted the mergify/bp/8.15/pr-41868 branch December 5, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts There is a conflict in the backported pull request Team:Security-Linux Platform Linux Platform Team in Security Solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants