Skip to content

[FlakyTest] TestFileWatcher/does_not_emit_events_for_empty_files/emits_a_create_event_once_something_is_written_to_the_empty_file#41848

Merged
khushijain21 merged 5 commits intoelastic:mainfrom
khushijain21:flaky_test
Dec 2, 2024
Merged

Conversation

@khushijain21
Copy link
Copy Markdown
Contributor

@khushijain21 khushijain21 commented Dec 2, 2024 •
edited
Loading

Proposed commit message

This test fails due to timing in file creation and subsequent testing for file existence. This test case is especially hard to manifest if your file system caches file creation operation. The provided changes were tested multiple times in an isolated GCP environment and was not reproducible.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #41209

@khushijain21 khushijain21 requested a review from a team as a code owner December 2, 2024 03:30
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 2, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 2, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 2, 2024
@khushijain21 khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 2, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 2, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2024
@khushijain21 khushijain21 merged commit 1660894 into elastic:main Dec 2, 2024
mergify bot pushed a commit that referenced this pull request Dec 2, 2024
@khushijain21 @mergify
[FlakyTest] TestFileWatcher/does_not_emit_events_for_empty_files/emit…
56c7533 
…s_a_create_event_once_something_is_written_to_the_empty_file (#41848)

* Fixes flaky test TestFileWatcher

(cherry picked from commit 1660894)
@mergify mergify bot mentioned this pull request Dec 2, 2024
Merged
6 tasks
khushijain21 added a commit that referenced this pull request Dec 3, 2024
@mergify @khushijain21
[FlakyTest] TestFileWatcher/does_not_emit_events_for_empty_files/emit…
2aaf2b2 
…s_a_create_event_once_something_is_written_to_the_empty_file (#41848) (#41851)

* Fixes flaky test TestFileWatcher

(cherry picked from commit 1660894)

Co-authored-by: Khushi Jain <khushi.jain@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauri870 mauri870 mauri870 approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@khushijain21 khushijain21

Labels

backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestFileWatcher/does_not_emit_events_for_empty_files/emits_a_create_event_once_something_is_written_to_the_empty_file

3 participants

@khushijain21 @elasticmachine @mauri870