Skip to content

[8.x](backport #41848) [FlakyTest] TestFileWatcher/does_not_emit_events_for_empty_files/emits_a_create_event_once_something_is_written_to_the_empty_file#41851

Merged
khushijain21 merged 1 commit into8.xfrom
mergify/bp/8.x/pr-41848
Dec 3, 2024
Merged

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Dec 2, 2024 •
edited by zube bot
Loading

Proposed commit message

This test fails due to timing in file creation and subsequent testing for file existence. This test case is especially hard to manifest if your file system caches file creation operation. The provided changes were tested multiple times in an isolated GCP environment and was not reproducible.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #41209

This is an automatic backport of pull request #41848 done by [Mergify](https://mergify.com).

@khushijain21 @mergify
[FlakyTest] TestFileWatcher/does_not_emit_events_for_empty_files/emit…
56c7533 
…s_a_create_event_once_something_is_written_to_the_empty_file (#41848)

* Fixes flaky test TestFileWatcher

(cherry picked from commit 1660894)
@mergify mergify bot requested a review from a team as a code owner December 2, 2024 13:50
@mergify mergify bot added the backport label Dec 2, 2024
@mergify mergify bot requested review from VihasMakwana and faec and removed request for a team December 2, 2024 13:50
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2024
@khushijain21 khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 3, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 3, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 3, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@khushijain21 khushijain21 merged commit 2aaf2b2 into 8.x Dec 3, 2024
@khushijain21 khushijain21 deleted the mergify/bp/8.x/pr-41848 branch December 3, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@faec faec Awaiting requested review from faec faec was automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@khushijain21 khushijain21

Labels

backport Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elasticmachine @khushijain21