Re-enable TestGroup_Go and fix flaky behavior#41230
Merged
mauri870 merged 1 commit intoelastic:mainfrom Oct 15, 2024
Merged
Conversation
910ecd2 to
63a1d3a
Compare
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
rdner
approved these changes
Oct 14, 2024
belimawr
approved these changes
Oct 14, 2024
Contributor
|
@mauri870 did you run this test with the race detector enabled? Looking at the improvements you did, it looks like the older version of the test should have been flagged by it 🤔 |
Member
Author
You are right, perhaps it was not a race condition per-se. I noticed that sometimes the contents of the log would not include log messages from both goroutines, even when both had finished executing already. I think the changes to the logger are still welcome tho, it is now safe to use in multiple goroutines without syncronization. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
(cherry picked from commit 66dacd9)
mauri870
added a commit
that referenced
this pull request
Oct 15, 2024
3 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR re-enables the TestGroup_Go test, which was skipped in #41223. It also includes fixes to mitigate flakiness in the test logger caused by timming issues and ensures proper waiting for success conditions within the tests.
How to test this PR locally
Related issues